1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
|
import os, unittest, time, traceback, sys
from commontest import *
import rdiff_backup.Security as Security
#Log.setverbosity(5)
class SecurityTest(unittest.TestCase):
def assert_exc_sec(self, exc):
"""Fudge - make sure exception is a security violation
This is necessary because of some kind of pickling/module
problem.
"""
if not isinstance(exc, Security.Violation):
type, value, tb = sys.exc_info()
print "".join(traceback.format_tb(tb))
raise exc
#assert str(exc).find("Security") >= 0, "%s\n%s" % (exc, repr(exc))
def test_vet_request_ro(self):
"""Test vetting of ConnectionRequests on read-only server"""
remote_cmd = "../rdiff-backup --server --restrict-read-only foo"
conn = SetConnections.init_connection(remote_cmd)
assert type(conn.os.getuid()) is type(5)
try: conn.os.remove("/tmp/foobar")
except Exception, e: self.assert_exc_sec(e)
else: assert 0, "No exception raised"
SetConnections.CloseConnections()
def test_vet_request_minimal(self):
"""Test vetting of ConnectionRequests on minimal server"""
remote_cmd = "../rdiff-backup --server --restrict-update-only foo"
conn = SetConnections.init_connection(remote_cmd)
assert type(conn.os.getuid()) is type(5)
try: conn.os.remove("/tmp/foobar")
except Exception, e: self.assert_exc_sec(e)
else: assert 0, "No exception raised"
SetConnections.CloseConnections()
def test_vet_rpath(self):
"""Test to make sure rpaths not in restricted path will be rejected"""
remote_cmd = "../rdiff-backup --server --restrict-update-only foo"
conn = SetConnections.init_connection(remote_cmd)
for rp in [RPath(Globals.local_connection, "blahblah"),
RPath(conn, "foo/bar")]:
conn.Globals.set("TEST_var", rp)
assert conn.Globals.get("TEST_var").path == rp.path
for path in ["foobar", "/usr/local", "foo/../bar"]:
try:
rp = rpath.RPath(conn, path)
conn.Globals.set("TEST_var", rp)
except Exception, e:
self.assert_exc_sec(e)
continue
assert 0, "No violation raised by rp %s" % (rp,)
SetConnections.CloseConnections()
def test_vet_rpath_root(self):
"""Test vetting when restricted to root"""
remote_cmd = "../rdiff-backup --server --restrict-update-only /"
conn = SetConnections.init_connection(remote_cmd)
for rp in [RPath(Globals.local_connection, "blahblah"),
RPath(conn, "foo/bar")]:
conn.Globals.set("TEST_var", rp)
assert conn.Globals.get("TEST_var").path == rp.path
SetConnections.CloseConnections()
def secure_rdiff_backup(self, in_dir, out_dir, in_local, restrict_args,
extra_args = "", success = 1, current_time = None):
"""Run rdiff-backup locally, with given restrict settings"""
if not current_time: current_time = int(time.time())
prefix = ('rdiff-backup --current-time %s ' % (current_time,) +
'--remote-schema %s ')
if in_local: out_dir = ("'rdiff-backup %s --server'::%s" %
(restrict_args, out_dir))
else: in_dir = ("'rdiff-backup %s --server'::%s" %
(restrict_args, in_dir))
cmdline = "%s %s %s %s" % (prefix, extra_args, in_dir, out_dir)
print "Executing:", cmdline
exit_val = os.system(cmdline)
if success: assert not exit_val
else: assert exit_val, "Success when wanted failure"
def test_restrict_positive(self):
"""Test that --restrict switch doesn't get in the way
This makes sure that basic backups with the restrict operator
work, (initial backup, incremental, restore).
"""
Myrm("testfiles/output")
self.secure_rdiff_backup('testfiles/various_file_types',
'testfiles/output', 1,
'--restrict testfiles/output',
current_time = 10000)
# Note the backslash below -- test for bug in path normalization
self.secure_rdiff_backup('testfiles/various_file_types',
'testfiles/output', 1,
'--restrict testfiles/output/')
Myrm("testfiles/restore_out")
self.secure_rdiff_backup('testfiles/output',
'testfiles/restore_out', 1,
'--restrict testfiles/restore_out',
extra_args = '-r now')
def test_restrict_negative(self):
"""Test that --restrict switch denies certain operations"""
# Backup to wrong directory
Myrm("testfiles/output testfiles/output2")
self.secure_rdiff_backup('testfiles/various_file_types',
'testfiles/output2', 1,
'--restrict testfiles/output',
success = 0)
# Restore to wrong directory
Myrm("testfiles/output testfiles/restore_out")
rdiff_backup(1, 1, 'testfiles/various_file_types',
'testfiles/output')
self.secure_rdiff_backup('testfiles/output',
'testfiles/restore_out', 1,
'--restrict testfiles/output2',
extra_args = '-r now',
success = 0)
# Backup from wrong directory
Myrm("testfiles/output")
self.secure_rdiff_backup('testfiles/various_file_types',
'testfiles/output', 0,
'--restrict testfiles/foobar',
success = 0)
def test_restrict_readonly_positive(self):
"""Test that --restrict-read-only switch doesn't impair normal ops"""
Myrm("testfiles/output testfiles/restore_out")
self.secure_rdiff_backup('testfiles/various_file_types',
'testfiles/output', 0,
'--restrict-read-only testfiles/various_file_types')
self.secure_rdiff_backup('testfiles/output',
'testfiles/restore_out', 0,
'--restrict-read-only testfiles/output',
extra_args = '-r now')
def test_restrict_readonly_negative(self):
"""Test that --restrict-read-only doesn't allow too much"""
# Backup to restricted directory
Myrm('testfiles/output')
self.secure_rdiff_backup('testfiles/various_file_types',
'testfiles/output', 1,
'--restrict-read-only testfiles/output',
success = 0)
# Restore to restricted directory
Myrm('testfiles/output testfiles/restore_out')
rdiff_backup(1, 1, 'testfiles/various_file_types', 'testfiles/output')
self.secure_rdiff_backup('testfiles/output',
'testfiles/restore_out', 1,
'--restrict-read-only testfiles/restore_out',
extra_args = '-r now',
success = 0)
def test_restrict_updateonly_positive(self):
"""Test that --restrict-update-only allows intended use"""
Myrm('testfiles/output')
rdiff_backup(1, 1, 'testfiles/various_file_types', 'testfiles/output',
current_time = 10000)
self.secure_rdiff_backup('testfiles/various_file_types',
'testfiles/output', 1,
'--restrict-update-only testfiles/output')
def test_restrict_updateonly_negative(self):
"""Test that --restrict-update-only impairs unintended"""
Myrm('testfiles/output')
self.secure_rdiff_backup('testfiles/various_file_types',
'testfiles/output', 1,
'--restrict-update-only testfiles/output',
success = 0)
Myrm('testfiles/output testfiles/restore_out')
rdiff_backup(1, 1, 'testfiles/various_file_types', 'testfiles/output')
self.secure_rdiff_backup('testfiles/output',
'testfiles/restore_out', 1,
'--restrict-update-only testfiles/restore_out',
extra_args = '-r now',
success = 0)
def test_restrict_bug(self):
"""Test for bug 14209 --- mkdir outside --restrict arg"""
Myrm('testfiles/output')
self.secure_rdiff_backup('testfiles/various_file_types',
'testfiles/output', 1,
'--restrict foobar', success = 0)
output = rpath.RPath(Globals.local_connection, 'testfiles/output')
assert not output.lstat()
def test_quoting_bug(self):
"""Test for bug 14545 --- quoting causes bad violation"""
Myrm('testfiles/output')
self.secure_rdiff_backup('testfiles/various_file_types',
'testfiles/output', 1, '',
extra_args = '--override-chars-to-quote e')
if __name__ == "__main__": unittest.main()
|
