summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordvora-h <67596500+dvora-h@users.noreply.github.com>2022-02-06 13:17:45 +0200
committerGitHub <noreply@github.com>2022-02-06 13:17:45 +0200
commitba3134cd6bbd9093028badfb3f37f214b6668055 (patch)
treec7814cfa0344c99219091b52438095590a3dc311
parentf9d8091bec3e83cbc0a699ac7b79894559ee0b3f (diff)
downloadredis-py-ba3134cd6bbd9093028badfb3f37f214b6668055.tar.gz
Throw NotImplementedError for HELLO (#1912)
* unsupported hello * add test and docstring * linters * fix docstring * linters * linters
-rw-r--r--redis/commands/core.py9
-rw-r--r--tests/test_commands.py5
2 files changed, 14 insertions, 0 deletions
diff --git a/redis/commands/core.py b/redis/commands/core.py
index 139208e..1b8cb80 100644
--- a/redis/commands/core.py
+++ b/redis/commands/core.py
@@ -1087,6 +1087,15 @@ class ManagementCommands:
"""
return self.execute_command("WAIT", num_replicas, timeout, **kwargs)
+ def hello(self):
+ """
+ This function throws a NotImplementedError since it is intentionally
+ not supported.
+ """
+ raise NotImplementedError(
+ "HELLO is intentionally not implemented in the client."
+ )
+
def failover(self):
"""
This function throws a NotImplementedError since it is intentionally
diff --git a/tests/test_commands.py b/tests/test_commands.py
index f2d5ed9..7d98665 100644
--- a/tests/test_commands.py
+++ b/tests/test_commands.py
@@ -624,6 +624,11 @@ class TestRedisCommands:
assert isinstance(r.client_getredir(), int)
assert r.client_getredir() == -1
+ @skip_if_server_version_lt("6.0.0")
+ def test_hello_notI_implemented(self, r):
+ with pytest.raises(NotImplementedError):
+ r.hello()
+
def test_config_get(self, r):
data = r.config_get()
assert len(data.keys()) > 10