diff options
author | Andrew Brookins <andrew.brookins@redislabs.com> | 2020-07-10 10:54:16 -0700 |
---|---|---|
committer | Andrew Brookins <andrew.brookins@redislabs.com> | 2020-07-10 10:54:16 -0700 |
commit | e0460b2f5004d068b83a4b701413d9ac64e0e04f (patch) | |
tree | ed6490809a2bd7910a33238d4de5b4c38cdabfda | |
parent | a1e5a7685fda4fc8ebe6456988c18e14724bb05a (diff) | |
download | redis-py-e0460b2f5004d068b83a4b701413d9ac64e0e04f.tar.gz |
Use the existing --redis-url param to get master host
-rw-r--r-- | Makefile | 2 | ||||
-rw-r--r-- | tests/conftest.py | 16 |
2 files changed, 8 insertions, 10 deletions
@@ -10,4 +10,4 @@ dev: test: dev find . -name "*.pyc" -exec rm -f {} \; - docker-compose run test tox -- --redis-url="redis://master:6379/9" --redis-master-host=master + docker-compose run test tox -- --redis-url=redis://master:6379/9 diff --git a/tests/conftest.py b/tests/conftest.py index 704a7e3..caca8cc 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -4,6 +4,7 @@ import pytest import redis from mock import Mock +from redis._compat import urlparse from distutils.version import StrictVersion @@ -14,19 +15,14 @@ REDIS_6_VERSION = '5.9.0' REDIS_INFO = {} -DEFAULT_REDIS_URL = "redis://localhost:6379/9" -DEFAULT_REDIS_MASTER_HOST = "localhost" +default_redis_url = "redis://localhost:6379/9" def pytest_addoption(parser): - parser.addoption('--redis-url', default=DEFAULT_REDIS_URL, + parser.addoption('--redis-url', default=default_redis_url, action="store", help="Redis connection string," " defaults to `%(default)s`") - parser.addoption('--redis-master-host', default=DEFAULT_REDIS_MASTER_HOST, - action="store", - help="Redis master hostname," - " defaults to `%(default)s`") def _get_info(redis_url): @@ -161,9 +157,11 @@ def mock_cluster_resp_slaves(request, **kwargs): return _gen_cluster_mock_resp(r, response) -@pytest.fixture(scope="module") +@pytest.fixture(scope="session") def master_host(request): - yield request.config.getoption("--redis-master-host") + url = request.config.getoption("--redis-url") + parts = urlparse(url) + yield parts.hostname def wait_for_command(client, monitor, command): |