diff options
| author | Chayim <chayim@users.noreply.github.com> | 2021-12-23 09:33:02 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-23 09:33:02 +0200 |
| commit | 940d9fc428c3dbe320af003befabe812a8d8537b (patch) | |
| tree | ff8ab3aa080fab28e2ed0f2b402317bfff14fc3c | |
| parent | 989d06d0832c2cccdb5b74f1b2afab2b2441fc79 (diff) | |
| download | redis-py-940d9fc428c3dbe320af003befabe812a8d8537b.tar.gz | |
Removing lots-of-pythons container (#1827)
| -rw-r--r-- | CONTRIBUTING.md | 16 | ||||
| -rw-r--r-- | tox.ini | 6 |
2 files changed, 7 insertions, 15 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 04f989a..0f9ca0b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -32,7 +32,7 @@ Here's how to get started with your code contribution: 1. Create your own fork of redis-py 2. Do the changes in your fork -3. +3. *Create a virtualenv and install the development dependencies from the dev_requirements.txt file:* a. python -m venv .venv @@ -69,12 +69,12 @@ configuration](https://redis.io/topics/sentinel). ## Testing -Call `invoke tests` to run all tests, or `invoke all-tests` to run linters -tests as well. With the 'tests' and 'all-tests' targets, all Redis and -RedisCluster tests will be run. +Call `invoke tests` to run all tests, or `invoke all-tests` to run linters +tests as well. With the 'tests' and 'all-tests' targets, all Redis and +RedisCluster tests will be run. -It is possible to run only Redis client tests (with cluster mode disabled) by -using `invoke standalone-tests`; similarly, RedisCluster tests can be run by using +It is possible to run only Redis client tests (with cluster mode disabled) by +using `invoke standalone-tests`; similarly, RedisCluster tests can be run by using `invoke cluster-tests`. Each run of tox starts and stops the various dockers required. Sometimes @@ -85,9 +85,7 @@ tests against multiple versions of python. Feel free to test your changes against all the python versions supported, as declared by the tox.ini file (eg: tox -e py39). If you have the various python versions on your desktop, you can run *tox* by itself, to test all supported -versions. Alternatively, as your source code is mounted in the -**lots-of-pythons** docker, you can start exploring from there, with all -supported python versions! +versions. ### Docker Tips @@ -73,12 +73,6 @@ ports = 36379:6379/tcp healtcheck_cmd = python -c "import socket;print(True) if 0 == socket.socket(socket.AF_INET, socket.SOCK_STREAM).connect_ex(('127.0.0.1',36379)) else False" -[docker:lots-of-pythons] -name = lots-of-pythons -image = redisfab/lots-of-pythons:latest -volumes = - bind:rw:{toxinidir}:/data - [docker:redis_cluster] name = redis_cluster image = redisfab/redis-py-cluster:6.2.6-buster |