summaryrefslogtreecommitdiff
path: root/redis/client.py
diff options
context:
space:
mode:
authorAndy McCurdy <andy@andymccurdy.com>2020-02-01 22:38:37 -0800
committerAndy McCurdy <andy@andymccurdy.com>2020-02-01 22:38:37 -0800
commit1b050753d6ec6a6630c2cfd83c2cfbd741a3ced3 (patch)
tree8eeefe7db936c5e5ed843b6433fa95459c6b6188 /redis/client.py
parent5a1f3c448063b3e30d3283cd93ef50973abc3806 (diff)
downloadredis-py-1b050753d6ec6a6630c2cfd83c2cfbd741a3ced3.tar.gz
remove Redis and ConnectionPool __eq__ comparison
After further thought this was a bad idea. Just because two connection pools share the same connection arguments does not make them equal. It would seem quite odd if pool_a == pool_b yet pool_a.disconnect() doesn't close all of pool_b's connections. Ref #1240 Fixes #1277 Fixes #1275 Fixes #1267 Fixes #1273
Diffstat (limited to 'redis/client.py')
-rwxr-xr-xredis/client.py6
1 files changed, 0 insertions, 6 deletions
diff --git a/redis/client.py b/redis/client.py
index 040d131..dde701f 100755
--- a/redis/client.py
+++ b/redis/client.py
@@ -746,12 +746,6 @@ class Redis(object):
def __repr__(self):
return "%s<%s>" % (type(self).__name__, repr(self.connection_pool))
- def __eq__(self, other):
- return (
- isinstance(other, self.__class__)
- and self.connection_pool == other.connection_pool
- )
-
def set_response_callback(self, command, callback):
"Set a custom Response Callback"
self.response_callbacks[command] = callback