diff options
| author | Andy McCurdy <andy@andymccurdy.com> | 2020-02-01 22:38:37 -0800 |
|---|---|---|
| committer | Andy McCurdy <andy@andymccurdy.com> | 2020-02-01 22:38:37 -0800 |
| commit | 1b050753d6ec6a6630c2cfd83c2cfbd741a3ced3 (patch) | |
| tree | 8eeefe7db936c5e5ed843b6433fa95459c6b6188 /redis/connection.py | |
| parent | 5a1f3c448063b3e30d3283cd93ef50973abc3806 (diff) | |
| download | redis-py-1b050753d6ec6a6630c2cfd83c2cfbd741a3ced3.tar.gz | |
remove Redis and ConnectionPool __eq__ comparison
After further thought this was a bad idea. Just because two connection
pools share the same connection arguments does not make them equal.
It would seem quite odd if pool_a == pool_b yet pool_a.disconnect() doesn't
close all of pool_b's connections.
Ref #1240
Fixes #1277
Fixes #1275
Fixes #1267
Fixes #1273
Diffstat (limited to 'redis/connection.py')
| -rwxr-xr-x | redis/connection.py | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/redis/connection.py b/redis/connection.py index bf892e9..2323365 100755 --- a/redis/connection.py +++ b/redis/connection.py @@ -1100,12 +1100,6 @@ class ConnectionPool(object): repr(self.connection_class(**self.connection_kwargs)), ) - def __eq__(self, other): - return ( - isinstance(other, self.__class__) - and self.connection_kwargs == other.connection_kwargs - ) - def reset(self): self._lock = threading.RLock() self._created_connections = 0 |