From a0509f0fb8a0db6f0a7a77568f19dbeb65fef031 Mon Sep 17 00:00:00 2001 From: Andy Grover Date: Fri, 25 Oct 2013 18:43:32 -0700 Subject: Add rtslib-saveconfig and rtslib-restoreconfig scripts Targetcli is not scriptable. One way around this is to modify or create the json describing the config directly, but even then, targetcli is needed to save or restore the json file. These new scripts enable saving or restoring a json-based configuration to not rely on calling targetcli, or even being installed. These scripts and just rtslib can properly return exit status & stderr output if something goes wrong. Signed-off-by: Andy Grover --- scripts/rtslib-restoreconfig | 68 ++++++++++++++++++++++++++++++++++++++++++++ scripts/rtslib-saveconfig | 56 ++++++++++++++++++++++++++++++++++++ 2 files changed, 124 insertions(+) create mode 100755 scripts/rtslib-restoreconfig create mode 100755 scripts/rtslib-saveconfig (limited to 'scripts') diff --git a/scripts/rtslib-restoreconfig b/scripts/rtslib-restoreconfig new file mode 100755 index 0000000..cc03fbd --- /dev/null +++ b/scripts/rtslib-restoreconfig @@ -0,0 +1,68 @@ +#!/usr/bin/python +''' +rtslib-restoreconfig + +This file is part of RTSLib. +Copyright (c) 2013 by Red Hat, Inc. + +Licensed under the Apache License, Version 2.0 (the "License"); you may +not use this file except in compliance with the License. You may obtain +a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +License for the specific language governing permissions and limitations +under the License. +''' + +# +# A script to restore LIO configuration from a file in json format +# + +from __future__ import print_function + +from rtslib import RTSRoot +import os +import sys +import json + +default_save_file = "/etc/target/saveconfig.json" +err = sys.stderr + +if os.geteuid() != 0: + print("Must run as root", file=err) + sys.exit(-1) + +if not len(sys.argv) <= 2 and sys.argv[1] == "--help": + print("syntax: %s [file_to_restore_from]" % sys.argv[0], file=err) + print(" default file is: %s" % default_save_file, file=err) + sys.exit(-1) + +if len(sys.argv) == 2: + savefile = os.path.expanduser(sys.argv[1]) +else: + savefile = default_save_file + +if not os.path.isfile(savefile): + print("Restore file %s not found" % savefile, file=err) + sys.exit(-1) + +with open(savefile, "r") as f: + try: + config = json.loads(f.read()) + except ValueError: + print("Error parsing savefile: %s" % savefile, file=err) + sys.exit(-1) + + errors = RTSRoot().restore(config, clear_existing=True) + + if errors: + print("Restore failed, %d errors:" % len(errors), file=err) + + for error in errors: + print(error, file=err) + + sys.exit(-1) diff --git a/scripts/rtslib-saveconfig b/scripts/rtslib-saveconfig new file mode 100755 index 0000000..b8791d1 --- /dev/null +++ b/scripts/rtslib-saveconfig @@ -0,0 +1,56 @@ +#!/usr/bin/python +''' +rtslib-saveconfig + +This file is part of RTSLib. +Copyright (c) 2013 by Red Hat, Inc. + +Licensed under the Apache License, Version 2.0 (the "License"); you may +not use this file except in compliance with the License. You may obtain +a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +License for the specific language governing permissions and limitations +under the License. +''' + +# +# A script to save LIO configuration to a file in json format +# + +from __future__ import print_function + +from rtslib import RTSRoot +import os +import sys +import stat +import json + +default_save_file = "/etc/target/saveconfig.json" +err = sys.stderr + +if os.geteuid() != 0: + print("Must run as root", file=err) + sys.exit(-1) + +if not len(sys.argv) <= 2 and sys.argv[1] == "--help": + print("syntax: %s [file_to_save_to]" % sys.argv[0], file=err) + print(" default file is: %s" % default_save_file, file=err) + sys.exit(-1) + +if len(sys.argv) == 2: + save_file = os.path.expanduser(sys.argv[1]) +else: + save_file = default_save_file + +with open(save_file+".temp", "w+") as f: + os.fchmod(f.fileno(), stat.S_IRUSR | stat.S_IWUSR) + f.write(json.dumps(RTSRoot().dump(), sort_keys=True, indent=2)) + f.write("\n") + os.fsync(f.fileno()) + +os.rename(save_file+".temp", save_file) -- cgit v1.2.1