diff options
| author | Hugo Rodger-Brown <hugo@yunojuno.com> | 2015-11-24 22:32:32 +0000 |
|---|---|---|
| committer | Hugo Rodger-Brown <hugo@yunojuno.com> | 2015-11-24 22:43:35 +0000 |
| commit | 0ef9524195546a607f43057207ac62c36e2bb38d (patch) | |
| tree | c2ba83377a866bec2aff6feb1d2e3b3f69a4084b /CREDITS | |
| parent | 2ed3d39c291080c61edd9139370939e1fdc3209a (diff) | |
| download | semantic-version-0ef9524195546a607f43057207ac62c36e2bb38d.tar.gz | |
Fix issue #33 - null VersionField breaks ORM
I've updated the `BaseSemVerField` method `get_prep_value` so that it
will return None when the field value is None, rather than the string
representation 'None'. Previously this would break the ORM, which would
save the string 'None' into the database, and then attempt to parse that
as a version number. This change means that the default empty value for
both VersionField and SpecField is None. Both derive from CharField,
which uses an empty string as its default empty value, however it seems
more logical in the case of these objects that no object is null, and
not an empty string.
Includes tests.
Diffstat (limited to 'CREDITS')
| -rw-r--r-- | CREDITS | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -20,6 +20,7 @@ The project has received contributions from (in alphabetical order): * Raphaël Barrois <raphael.barrois+semver@polytechnique.org> (https://github.com/rbarrois) * Michael Hrivnak <mhrivnak@hrivnak.org> (https://github.com/mhrivnak) * Rick Eyre <rick.eyre@outlook.com> (https://github.com/rickeyre) +* Hugo Rodger-Brown <hugo@yunojuno.com> (https://github.com/yunojuno) Contributor license agreement |