From 75914c67c77e94b0af71fbab424ad1e18e218b97 Mon Sep 17 00:00:00 2001 From: James Knight Date: Sun, 5 Dec 2021 15:03:57 -0500 Subject: drop translator-specific unknown_visit calls Removes the need for various translators from raising a `NotImplementedError` exception when missing support for a specific node type. docutils will already raise [1][2] a `NotImplementedError` exception for these cases. This help reduce the implementation inside Sphinx as well as prevents the possible undesired replication of unknown-node handling with third-party extensions [3]. In most cases, generating a warning message for an unsupported node type can be preferred. Providing an indication that a node is not supported can be easier for a user of Sphinx to understand a limitation of a builder over a generic "not implemented" exception. This commit takes the logging call which is already used by `texinfo` and applies it to the `SphinxTranslator` base class -- which any Sphinx translator implementation can use. [1]: https://repo.or.cz/docutils.git/blob/d169015ee0f412cffd69b33654d8a119d99bc0f3:/docutils/nodes.py#l2048 [2]: https://repo.or.cz/docutils.git/blob/53716a13b48128af6045139d3cd2909f61e7ed8e:/docutils/nodes.py#l1897 [3]: https://github.com/sphinx-doc/sphinx/issues/9921 Signed-off-by: James Knight --- sphinx/writers/texinfo.py | 4 ---- 1 file changed, 4 deletions(-) (limited to 'sphinx/writers/texinfo.py') diff --git a/sphinx/writers/texinfo.py b/sphinx/writers/texinfo.py index 6df558323..539a72388 100644 --- a/sphinx/writers/texinfo.py +++ b/sphinx/writers/texinfo.py @@ -1265,10 +1265,6 @@ class TexinfoTranslator(SphinxTranslator): logger.warning(__("unimplemented node type: %r"), node, location=node) - def unknown_visit(self, node: Node) -> None: - logger.warning(__("unknown node type: %r"), node, - location=node) - def unknown_departure(self, node: Node) -> None: pass -- cgit v1.2.1