diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2019-01-16 15:54:39 -0500 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2019-01-18 13:11:40 -0500 |
| commit | fe646671060815ff865e49b52d957c7f01220597 (patch) | |
| tree | 170499cfac9a0c6dcf3653f33c198fbe7ca90752 /migrate/changeset/ansisql.py | |
| parent | 8fd7226f186427d8f005c00ca155322f2f72078b (diff) | |
| download | sqlalchemy-migrate-fe646671060815ff865e49b52d957c7f01220597.tar.gz | |
Don't use deprecated / non-functional "force" parameter
The "force" parameter in SQLAlchemy IdentifierPreparer.quote()
has been a no-op since 0.9 in
https://github.com/sqlalchemy/sqlalchemy/commit/031ef0807838842a827135dbace760da7aec215e,
which was six years ago. In SQLAlchemy 1.3 this parameter
will be removed entirely. Bump requirements to 0.9 series
here and remove usage of the "force" flag.
Change-Id: I4492df2e7d2075fefbf13d6782de11f7d402f6b8
Diffstat (limited to 'migrate/changeset/ansisql.py')
| -rw-r--r-- | migrate/changeset/ansisql.py | 17 |
1 files changed, 7 insertions, 10 deletions
diff --git a/migrate/changeset/ansisql.py b/migrate/changeset/ansisql.py index a18d4ed..0a298a2 100644 --- a/migrate/changeset/ansisql.py +++ b/migrate/changeset/ansisql.py @@ -159,8 +159,7 @@ class ANSISchemaChanger(AlterTableVisitor, SchemaGenerator): def visit_table(self, table): """Rename a table. Other ops aren't supported.""" self.start_alter_table(table) - q = util.safe_quote(table) - self.append("RENAME TO %s" % self.preparer.quote(table.new_name, q)) + self.append("RENAME TO %s" % self.preparer.quote(table.new_name)) self.execute() def visit_index(self, index): @@ -170,19 +169,19 @@ class ANSISchemaChanger(AlterTableVisitor, SchemaGenerator): self.append("ALTER INDEX %s RENAME TO %s" % ( self.preparer.quote( self._validate_identifier( - index.name, True), index.quote), + index.name, True)), self.preparer.quote( self._validate_identifier( - index.new_name, True), index.quote))) + index.new_name, True)))) elif hasattr(self, '_index_identifier'): # SA >= 0.6.5, < 0.8 self.append("ALTER INDEX %s RENAME TO %s" % ( self.preparer.quote( self._index_identifier( - index.name), index.quote), + index.name)), self.preparer.quote( self._index_identifier( - index.new_name), index.quote))) + index.new_name)))) else: # SA >= 0.8 class NewName(object): @@ -229,8 +228,7 @@ class ANSISchemaChanger(AlterTableVisitor, SchemaGenerator): def start_alter_column(self, table, col_name): """Starts ALTER COLUMN""" self.start_alter_table(table) - q = util.safe_quote(table) - self.append("ALTER COLUMN %s " % self.preparer.quote(col_name, q)) + self.append("ALTER COLUMN %s " % self.preparer.quote(col_name)) def _visit_column_nullable(self, table, column, delta): nullable = delta['nullable'] @@ -253,8 +251,7 @@ class ANSISchemaChanger(AlterTableVisitor, SchemaGenerator): def _visit_column_name(self, table, column, delta): self.start_alter_table(table) - q = util.safe_quote(table) - col_name = self.preparer.quote(delta.current_name, q) + col_name = self.preparer.quote(delta.current_name) new_name = self.preparer.format_column(delta.result_column) self.append('RENAME COLUMN %s TO %s' % (col_name, new_name)) |