Handle the mssql port properly. If we're using the SQL Server driver then use the correct host,port syntax, otherwise use the Port= parameter in the connection string. Fixes #1192.

1 files changed, 9 insertions, 3 deletions

diff --git a/lib/sqlalchemy/databases/mssql.py b/lib/sqlalchemy/databases/mssql.py
index b254941ab..a313b98bc 100644
--- a/lib/sqlalchemy/databases/mssql.py
+++ b/lib/sqlalchemy/databases/mssql.py
@@ -797,12 +797,18 @@ class MSSQLDialect_pyodbc(MSSQLDialect):
         if 'dsn' in keys:
             connectors = ['dsn=%s' % keys.pop('dsn')]
         else:
+            port = ''
+            if 'port' in keys and (
+                keys.get('driver', 'SQL Server') == 'SQL Server'):
+                port = ',%d' % int(keys.pop('port'))
+
             connectors = ["DRIVER={%s}" % keys.pop('driver', 'SQL Server'),
-                          'Server=%s' % keys.pop('host', ''),
+                          'Server=%s%s' % (keys.pop('host', ''), port),
                           'Database=%s' % keys.pop('database', '') ]
-            if 'port' in keys:
+
+            if 'port' in keys and not port:
                 connectors.append('Port=%d' % int(keys.pop('port')))
-        
+
         user = keys.pop("user", None)
         if user:
             connectors.append("UID=%s" % user)