summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/dialects/mssql/pymssql.py
diff options
context:
space:
mode:
authorFederico Caselli <cfederico87@gmail.com>2021-06-21 21:01:57 +0200
committerFederico Caselli <cfederico87@gmail.com>2021-06-21 22:31:01 +0000
commita84881e1b7505c3ffb9b9f0ac2b227cbd650aac2 (patch)
tree5b3b9c56e95752f1dd8c1301c1d298455c50ae9e /lib/sqlalchemy/dialects/mssql/pymssql.py
parent2f100a7d4bb143e1f8674a388d8d305be3051bd6 (diff)
downloadsqlalchemy-a84881e1b7505c3ffb9b9f0ac2b227cbd650aac2.tar.gz
Improve regexp used by pymssql to parse db version
Made improvements to the server version regexp used by the pymssql dialect to prevent a regexp overflow in case of an invalid version string. Fixes: #5557 Change-Id: Ia3e95a9f11f5a121d84474c97f6b122cf8d9c9cf
Diffstat (limited to 'lib/sqlalchemy/dialects/mssql/pymssql.py')
-rw-r--r--lib/sqlalchemy/dialects/mssql/pymssql.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/sqlalchemy/dialects/mssql/pymssql.py b/lib/sqlalchemy/dialects/mssql/pymssql.py
index 4cc6c4696..a8361e990 100644
--- a/lib/sqlalchemy/dialects/mssql/pymssql.py
+++ b/lib/sqlalchemy/dialects/mssql/pymssql.py
@@ -94,7 +94,7 @@ class MSDialect_pymssql(MSDialect):
def _get_server_version_info(self, connection):
vers = connection.exec_driver_sql("select @@version").scalar()
- m = re.match(r"Microsoft .*? - (\d+).(\d+).(\d+).(\d+)", vers)
+ m = re.match(r"Microsoft .*? - (\d+)\.(\d+)\.(\d+)\.(\d+)", vers)
if m:
return tuple(int(x) for x in m.group(1, 2, 3, 4))
else: