summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/sql/expression.py
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2010-11-28 11:24:57 -0500
committerMike Bayer <mike_mp@zzzcomputing.com>2010-11-28 11:24:57 -0500
commit59a177a4c0bd69863e011e0f1c40e5b87fff99d3 (patch)
tree1074c72dd5b3fe06d30ee350d4ee2b86dafe71fe /lib/sqlalchemy/sql/expression.py
parentee25562461db46e31643a2f4ff9c981313a52dc3 (diff)
downloadsqlalchemy-59a177a4c0bd69863e011e0f1c40e5b87fff99d3.tar.gz
- _literal_as_text raises if the incoming arg is not a Visitable or basestring.
[ticket:1847]
Diffstat (limited to 'lib/sqlalchemy/sql/expression.py')
-rw-r--r--lib/sqlalchemy/sql/expression.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/sqlalchemy/sql/expression.py b/lib/sqlalchemy/sql/expression.py
index ede3235c5..3cfe0a14c 100644
--- a/lib/sqlalchemy/sql/expression.py
+++ b/lib/sqlalchemy/sql/expression.py
@@ -1056,8 +1056,10 @@ def _column_as_key(element):
def _literal_as_text(element):
if hasattr(element, '__clause_element__'):
return element.__clause_element__()
- elif not isinstance(element, Visitable):
+ elif isinstance(element, basestring):
return _TextClause(unicode(element))
+ elif not isinstance(element, Visitable):
+ raise exc.ArgumentError("SQL expression object or string expected.")
else:
return element