tweak for correlated subqueries here, seems to work for test_eager_relations:CorrelatedSubqueryTest but need some more testing here

1 files changed, 6 insertions, 1 deletions

diff --git a/lib/sqlalchemy/sql/util.py b/lib/sqlalchemy/sql/util.py
index 9a45a5777..511a5b0c2 100644
--- a/lib/sqlalchemy/sql/util.py
+++ b/lib/sqlalchemy/sql/util.py
@@ -100,7 +100,12 @@ def visit_binary_product(fn, expr):
     """
     stack = []
     def visit(element):
-        if element.__visit_name__ == 'binary' and \
+        if isinstance(element, (expression.FromClause, 
+                                expression._ScalarSelect)):
+            # we dont want to dig into correlated subqueries,
+            # those are just column elements by themselves
+            yield element
+        elif element.__visit_name__ == 'binary' and \
             operators.is_comparison(element.operator):
             stack.insert(0, element)
             for l in visit(element.left):