diff options
author | Michael Trier <mtrier@gmail.com> | 2008-07-29 03:08:38 +0000 |
---|---|---|
committer | Michael Trier <mtrier@gmail.com> | 2008-07-29 03:08:38 +0000 |
commit | c622a86286573f2029e93923c2d5a98379fb794b (patch) | |
tree | 27888336ac6e21db37b63774b6720ed5de05e8d6 /lib/sqlalchemy | |
parent | e411a837832f11707785962b06bf6ce0f3ac7e26 (diff) | |
download | sqlalchemy-c622a86286573f2029e93923c2d5a98379fb794b.tar.gz |
Raised an error when sqlite version does not support default values. Addresses #909 in a purposeful way.
Diffstat (limited to 'lib/sqlalchemy')
-rw-r--r-- | lib/sqlalchemy/databases/sqlite.py | 10 | ||||
-rw-r--r-- | lib/sqlalchemy/engine/base.py | 2 | ||||
-rw-r--r-- | lib/sqlalchemy/engine/default.py | 1 |
3 files changed, 11 insertions, 2 deletions
diff --git a/lib/sqlalchemy/databases/sqlite.py b/lib/sqlalchemy/databases/sqlite.py index b6e362ef2..b491ce07b 100644 --- a/lib/sqlalchemy/databases/sqlite.py +++ b/lib/sqlalchemy/databases/sqlite.py @@ -222,6 +222,8 @@ class SQLiteDialect(default.DefaultDialect): "and will cause errors in some cases. Version 2.1.3 " "or greater is recommended.") % '.'.join([str(subver) for subver in sqlite_ver])) + if self.dbapi.sqlite_version_info < (3, 3, 8): + self.supports_default_values = False self.supports_cast = (self.dbapi is None or vers(self.dbapi.sqlite_version) >= vers("3.2.3")) def dbapi(cls): @@ -439,8 +441,12 @@ class SQLiteCompiler(compiler.DefaultCompiler): preparer = self.preparer if not colparams: - return "INSERT INTO %s DEFAULT VALUES" % ( - (preparer.format_table(insert_stmt.table),)) + if not self.dialect.supports_default_values: + raise exc.NotSupportedError( + "The version of SQLite you are using, %s, does not support DEFAULT VALUES." % (self.dialect.dbapi.sqlite_version)) + + return ("INSERT INTO %s DEFAULT VALUES" % ( + (preparer.format_table(insert_stmt.table),))) else: return ("INSERT INTO %s (%s) VALUES (%s)" % (preparer.format_table(insert_stmt.table), diff --git a/lib/sqlalchemy/engine/base.py b/lib/sqlalchemy/engine/base.py index 7cf098294..18e816546 100644 --- a/lib/sqlalchemy/engine/base.py +++ b/lib/sqlalchemy/engine/base.py @@ -101,6 +101,8 @@ class Dialect(object): result sets against textual statements where no explicit typemap was present. + supports_default_values + Indicates if the construct ``INSERT INTO tablename DEFAULT VALUES`` is supported """ def create_connect_args(self, url): diff --git a/lib/sqlalchemy/engine/default.py b/lib/sqlalchemy/engine/default.py index b68ce0818..a3ae6d456 100644 --- a/lib/sqlalchemy/engine/default.py +++ b/lib/sqlalchemy/engine/default.py @@ -39,6 +39,7 @@ class DefaultDialect(base.Dialect): supports_pk_autoincrement = True dbapi_type_map = {} default_paramstyle = 'named' + supports_default_values = True def __init__(self, convert_unicode=False, assert_unicode=False, encoding='utf-8', paramstyle=None, dbapi=None, **kwargs): self.convert_unicode = convert_unicode |