summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorGord Thompson <gord@gordthompson.com>2020-05-11 14:44:37 -0600
committerGord Thompson <gord@gordthompson.com>2020-05-11 14:44:37 -0600
commitcc97dade0de008ce923dbb94db21a8e1ccb5bb22 (patch)
tree280f46297d20b9cdf7439c0bbb92dc2d3587be93 /lib
parent5311a8531c621760ced0b3d0a5454e8c22871d66 (diff)
downloadsqlalchemy-cc97dade0de008ce923dbb94db21a8e1ccb5bb22.tar.gz
Move supports_sane_rowcount_returning = False to dialect level
Fixes: #5321 Change-Id: Id83e98e9013818424c133297a850746302633158
Diffstat (limited to 'lib')
-rw-r--r--lib/sqlalchemy/connectors/pyodbc.py3
-rw-r--r--lib/sqlalchemy/dialects/mssql/pyodbc.py3
2 files changed, 5 insertions, 1 deletions
diff --git a/lib/sqlalchemy/connectors/pyodbc.py b/lib/sqlalchemy/connectors/pyodbc.py
index d0c114822..cd79a3ada 100644
--- a/lib/sqlalchemy/connectors/pyodbc.py
+++ b/lib/sqlalchemy/connectors/pyodbc.py
@@ -14,7 +14,8 @@ from .. import util
class PyODBCConnector(Connector):
driver = "pyodbc"
- supports_sane_rowcount_returning = False
+ # this is no longer False for pyodbc in general
+ supports_sane_rowcount_returning = True
supports_sane_multi_rowcount = False
supports_unicode_statements = True
diff --git a/lib/sqlalchemy/dialects/mssql/pyodbc.py b/lib/sqlalchemy/dialects/mssql/pyodbc.py
index 5cb92ef07..ff164e886 100644
--- a/lib/sqlalchemy/dialects/mssql/pyodbc.py
+++ b/lib/sqlalchemy/dialects/mssql/pyodbc.py
@@ -314,6 +314,9 @@ class MSExecutionContext_pyodbc(MSExecutionContext):
class MSDialect_pyodbc(PyODBCConnector, MSDialect):
+ # mssql still has problems with this on Linux
+ supports_sane_rowcount_returning = False
+
execution_ctx_cls = MSExecutionContext_pyodbc
colspecs = util.update_copy(