Cleaned up the create_connect_args so that it makes no expectations about keys. Fixes 1193. Added server version info into mssql pyodbc dialect.

1 files changed, 16 insertions, 0 deletions

diff --git a/test/dialect/mssql.py b/test/dialect/mssql.py
index 02c583d5d..4708cc28c 100755
--- a/test/dialect/mssql.py
+++ b/test/dialect/mssql.py
@@ -5,6 +5,7 @@ from sqlalchemy.orm import *
 from sqlalchemy import exc
 from sqlalchemy.sql import table, column
 from sqlalchemy.databases import mssql
+import sqlalchemy.engine.url as url
 from testlib import *
 
 
@@ -362,5 +363,20 @@ class MatchTest(TestBase, AssertsCompiledSQL):
         self.assertEquals([1, 3, 5], [r.id for r in results])
 
 
+class ParseConnectTest(TestBase, AssertsCompiledSQL):
+    __only_on__ = 'mssql'
+
+    def test_pyodbc_connect(self):
+        u = url.make_url('mssql://username:password@hostspec/database')
+        dialect = mssql.MSSQLDialect_pyodbc()
+        connection = dialect.create_connect_args(u)
+        self.assertEquals([['DRIVER={SQL Server};Server=hostspec;Database=database;UID=username;PWD=password'], {}], connection)
+
+    def test_pyodbc_extra_connect(self):
+        u = url.make_url('mssql://username:password@hostspec/database?LANGUAGE=us_english&foo=bar')
+        dialect = mssql.MSSQLDialect_pyodbc()
+        connection = dialect.create_connect_args(u)
+        self.assertEquals([['DRIVER={SQL Server};Server=hostspec;Database=database;UID=username;PWD=password;foo=bar;LANGUAGE=us_english'], {}], connection)
+
 if __name__ == "__main__":
     testenv.main()