diff options
Diffstat (limited to 'test')
| -rw-r--r-- | test/dialect/test_mssql.py | 11 | ||||
| -rw-r--r-- | test/orm/test_query.py | 3 |
2 files changed, 6 insertions, 8 deletions
diff --git a/test/dialect/test_mssql.py b/test/dialect/test_mssql.py index 74e96c8ef..6ae0dfc45 100644 --- a/test/dialect/test_mssql.py +++ b/test/dialect/test_mssql.py @@ -183,10 +183,9 @@ class CompileTest(fixtures.TestBase, AssertsCompiledSQL): ]: self.assert_compile(expr, compile, dialect=mxodbc_dialect) - @testing.uses_deprecated def test_in_with_subqueries(self): - """Test that when using subqueries in a binary expression - the == and != are changed to IN and NOT IN respectively. + """Test removal of legacy behavior that converted "x==subquery" + to use IN. """ @@ -194,14 +193,14 @@ class CompileTest(fixtures.TestBase, AssertsCompiledSQL): self.assert_compile(t.select().where(t.c.somecolumn == t.select()), 'SELECT sometable.somecolumn FROM ' - 'sometable WHERE sometable.somecolumn IN ' + 'sometable WHERE sometable.somecolumn = ' '(SELECT sometable.somecolumn FROM ' 'sometable)') self.assert_compile(t.select().where(t.c.somecolumn != t.select()), 'SELECT sometable.somecolumn FROM ' - 'sometable WHERE sometable.somecolumn NOT ' - 'IN (SELECT sometable.somecolumn FROM ' + 'sometable WHERE sometable.somecolumn != ' + '(SELECT sometable.somecolumn FROM ' 'sometable)') def test_count(self): diff --git a/test/orm/test_query.py b/test/orm/test_query.py index 6e945aa72..96414f07a 100644 --- a/test/orm/test_query.py +++ b/test/orm/test_query.py @@ -822,7 +822,6 @@ class ExpressionTest(QueryTest, AssertsCompiledSQL): 'IN (SELECT users.id FROM users WHERE ' 'users.id = :id_1)') - @testing.fails_on('mssql', "mssql doesn't allow col = <subquery>, sqla deprecated workaround") def test_param_transfer(self): User = self.classes.User @@ -830,7 +829,7 @@ class ExpressionTest(QueryTest, AssertsCompiledSQL): q = session.query(User.id).filter(User.id==bindparam('foo')).params(foo=7).subquery() - q = session.query(User).filter(User.id==q) + q = session.query(User).filter(User.id.in_(q)) eq_(User(id=7), q.one()) |