From bdd922ad0d94953c53e654893889e5aa7ed00685 Mon Sep 17 00:00:00 2001 From: Jason Kirtland Date: Wed, 12 Dec 2007 20:18:58 +0000 Subject: Some code-level docs for r3916 --- lib/sqlalchemy/databases/mysql.py | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'lib/sqlalchemy/databases/mysql.py') diff --git a/lib/sqlalchemy/databases/mysql.py b/lib/sqlalchemy/databases/mysql.py index ba0ad5e0a..122c24bff 100644 --- a/lib/sqlalchemy/databases/mysql.py +++ b/lib/sqlalchemy/databases/mysql.py @@ -1882,6 +1882,11 @@ class MySQLCompiler(compiler.DefaultCompiler): return "" def visit_join(self, join, asfrom=False, **kwargs): + # 'JOIN ... ON ...' for inner joins isn't available until 4.0. + # Apparently < 3.23.17 requires theta joins for inner joins + # (but not outer). Not generating these currently, but + # support can be added, preferably after dialects are + # refactored to be version-sensitive. return ''.join( (self.process(join.left, asfrom=True), (join.isouter and " LEFT OUTER JOIN " or " INNER JOIN "), -- cgit v1.2.1