From 25b8e89d3d425656e51438b5cac7e6e1f2592817 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Sun, 13 Sep 2020 10:36:16 -0400 Subject: Deprecate engine-wise ss cursors; repair mariadbconnector The server_side_cursors engine-wide feature relies upon regexp parsing of statements a well as general guessing as to when the feature should be used. This is not within the 2.0 way of doing things and should be removed. Additionally, mariadbconnector defaults to unbuffered cursors; add new cursor hooks so that mariadbconnector can specify buffered or unbuffered cursors without too much difficulty. This will also correctly default mariadbconnector to buffered cursors which should repair the segfaults we've been getting. Try to restore the assert_raises that was removed in 5b6dfc0c38bf1f01da4b8 to see if mariadbconnector segfaults are resolved. Change-Id: I77f1c972c742e40694972f578140bb0cac8c39eb --- lib/sqlalchemy/dialects/postgresql/asyncpg.py | 4 ---- 1 file changed, 4 deletions(-) (limited to 'lib/sqlalchemy/dialects/postgresql/asyncpg.py') diff --git a/lib/sqlalchemy/dialects/postgresql/asyncpg.py b/lib/sqlalchemy/dialects/postgresql/asyncpg.py index eb87249b4..780e23844 100644 --- a/lib/sqlalchemy/dialects/postgresql/asyncpg.py +++ b/lib/sqlalchemy/dialects/postgresql/asyncpg.py @@ -723,10 +723,6 @@ class PGDialect_asyncpg(PGDialect): }, ) - def __init__(self, server_side_cursors=False, **kwargs): - PGDialect.__init__(self, **kwargs) - self.server_side_cursors = server_side_cursors - @util.memoized_property def _dbapi_version(self): if self.dbapi and hasattr(self.dbapi, "__version__"): -- cgit v1.2.1