From ffa6f45ec392bdffd419484e1343c7853433d9c4 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Fri, 14 Feb 2014 14:32:00 -0500 Subject: - Revised this very old issue where the Postgresql "get primary key" reflection query were updated to take into account primary key constraints that were renamed; the newer query fails on very old versions of Postgresql such as version 7, so the old query is restored in those cases when server_version_info < (8, 0) is detected. #2291 --- lib/sqlalchemy/dialects/postgresql/base.py | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) (limited to 'lib/sqlalchemy/dialects/postgresql/base.py') diff --git a/lib/sqlalchemy/dialects/postgresql/base.py b/lib/sqlalchemy/dialects/postgresql/base.py index 29584d1eb..1b5927dbd 100644 --- a/lib/sqlalchemy/dialects/postgresql/base.py +++ b/lib/sqlalchemy/dialects/postgresql/base.py @@ -2026,7 +2026,21 @@ class PGDialect(default.DefaultDialect): table_oid = self.get_table_oid(connection, table_name, schema, info_cache=kw.get('info_cache')) - if self.server_version_info < (8, 4): + if self.server_version_info < (8, 0): + # the shortcoming of this query is that it will + # not detect a PK constraint that has been renamed. + # This query was removed with #2291, however it was reported + # that the newer queries do not work with PG 7 so here + # it is restored when old PG versions are detected. + PK_SQL = """ + SELECT attname FROM pg_attribute + WHERE attrelid = ( + SELECT indexrelid FROM pg_index i + WHERE i.indrelid = :table_oid + AND i.indisprimary = 't') + ORDER BY attnum + """ + elif self.server_version_info < (8, 4): # unnest() and generate_subscripts() both introduced in # version 8.4 PK_SQL = """ -- cgit v1.2.1