From 974b1bd0fc40e11fc2886b5a9fc333feeeebf546 Mon Sep 17 00:00:00 2001 From: Federico Caselli Date: Sat, 24 Sep 2022 15:50:26 +0200 Subject: Revert automatic set of sequence start to 1 The :class:`.Sequence` construct restores itself to the DDL behavior it had prior to the 1.4 series, where creating a :class:`.Sequence` with no additional arguments will emit a simple ``CREATE SEQUENCE`` instruction **without** any additional parameters for "start value". For most backends, this is how things worked previously in any case; **however**, for MS SQL Server, the default value on this database is ``-2**63``; to prevent this generally impractical default from taking effect on SQL Server, the :paramref:`.Sequence.start` parameter should be provided. As usage of :class:`.Sequence` is unusual for SQL Server which for many years has standardized on ``IDENTITY``, it is hoped that this change has minimal impact. Fixes: #7211 Change-Id: I1207ea10c8cb1528a1519a0fb3581d9621c27b31 --- test/dialect/postgresql/test_compiler.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'test/dialect/postgresql/test_compiler.py') diff --git a/test/dialect/postgresql/test_compiler.py b/test/dialect/postgresql/test_compiler.py index c763dbeac..96a8e7d5a 100644 --- a/test/dialect/postgresql/test_compiler.py +++ b/test/dialect/postgresql/test_compiler.py @@ -91,11 +91,11 @@ class SequenceTest(fixtures.TestBase, AssertsCompiledSQL): (SmallInteger, "AS SMALLINT "), (BigInteger, "AS BIGINT "), ) - def test_create_index_concurrently(self, type_, text): + def test_compile_type(self, type_, text): s = Sequence("s1", data_type=type_) self.assert_compile( schema.CreateSequence(s), - "CREATE SEQUENCE s1 %sSTART WITH 1" % text, + f"CREATE SEQUENCE s1 {text}".strip(), dialect=postgresql.dialect(), ) -- cgit v1.2.1