diff options
author | Bert JW Regeer <bertjw@regeer.org> | 2020-02-02 15:10:35 -0800 |
---|---|---|
committer | Bert JW Regeer <bertjw@regeer.org> | 2020-02-02 15:10:35 -0800 |
commit | 2fe8e54695ed038dadbb90e03140a1ab395d6629 (patch) | |
tree | e9d64780d02f6ad2caa06098851af37ca924a6cd /waitress/tests/test_parser.py | |
parent | ac0ca050046f1538346f3975487062186195f4ca (diff) | |
download | waitress-2fe8e54695ed038dadbb90e03140a1ab395d6629.tar.gz |
Add header parsing tests with short headers
While fixing the catastrophic backtracking a gap in tests led to a
potentially bad regex being considered that would have caused issues
with short header values.
This now adds a test to make sure we don't regress.
Diffstat (limited to 'waitress/tests/test_parser.py')
-rw-r--r-- | waitress/tests/test_parser.py | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/waitress/tests/test_parser.py b/waitress/tests/test_parser.py index 71703e2..b425131 100644 --- a/waitress/tests/test_parser.py +++ b/waitress/tests/test_parser.py @@ -433,6 +433,17 @@ class TestHTTPRequestParser(unittest.TestCase): self.assertIn("FOO", self.parser.headers) self.assertEqual(self.parser.headers["FOO"], "abrowser/0.001 (C O M M E N T)") + def test_parse_header_short_values(self): + from waitress.parser import ParsingError + + data = b"GET /foobar HTTP/1.1\r\none: 1\r\ntwo: 22\r\n" + self.parser.parse_header(data) + + self.assertIn("ONE", self.parser.headers) + self.assertIn("TWO", self.parser.headers) + self.assertEqual(self.parser.headers["ONE"], "1") + self.assertEqual(self.parser.headers["TWO"], "22") + class Test_split_uri(unittest.TestCase): def _callFUT(self, uri): |