delta/qt-creator.git/src/plugins/cppeditor/cpphoverhandler.cpp, branch 10.0 code.qt.io: qt-creator/qt-creator.git CppEditor: Move CppHoverHandler to its only point of use 2021-09-03T11:36:19+00:00 Christian Kandeler christian.kandeler@qt.io 2021-09-02T05:56:27+00:00 1d88a657475835b036272c3a522c612ecc082a87 No need to compile an extra translation unit for this. Change-Id: Ie21346700818ccadab864b77f13f167bd27a457a Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Christian Stenger <christian.stenger@qt.io> 
No need to compile an extra translation unit for this.

Change-Id: Ie21346700818ccadab864b77f13f167bd27a457a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Merge CppTools into CppEditor 2021-09-01T14:53:58+00:00 Christian Kandeler christian.kandeler@qt.io 2021-08-30T08:58:08+00:00 284817fae6514701902ccdb834c2faa46462f2e8 There was no proper separation of responsibilities between these plugins. In particular, CppTools had lots of editor-related functionality, so it's not clear why it was separated out in the first place. In fact, for a lot of code, it seemed quite arbitrary where it was put (just one example: switchHeaderSource() was in CppTools, wheras switchDeclarationDefinition() was in CppEditor). Merging the plugins will enable us to get rid of various convoluted pseudo-abstractions that were only introduced to keep up the artificial separation. Change-Id: Iafc3bce625b4794f6d4aa03df6cddc7f2d26716a Reviewed-by: Christian Stenger <christian.stenger@qt.io> 
There was no proper separation of responsibilities between these
plugins. In particular, CppTools had lots of editor-related
functionality, so it's not clear why it was separated out in the first
place.
In fact, for a lot of code, it seemed quite arbitrary where it was put
(just one example: switchHeaderSource() was in CppTools, wheras
switchDeclarationDefinition() was in CppEditor).
Merging the plugins will enable us to get rid of various convoluted
pseudo-abstractions that were only introduced to keep up the artificial
separation.

Change-Id: Iafc3bce625b4794f6d4aa03df6cddc7f2d26716a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
CppTools: Move CppHoverHandler to CppTools 2018-01-16T08:31:11+00:00 Nikolai Kosjar nikolai.kosjar@qt.io 2018-01-11T16:06:26+00:00 5e861d2be6729b7d4b0927b1d334f6298927013e This is in preparation for clang code model to provide its own hover handler. Change-Id: Ifbdd96f427989bd5d1fbc4badb9c38108485c2f2 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io> 
This is in preparation for clang code model to provide its own hover
handler.

Change-Id: Ifbdd96f427989bd5d1fbc4badb9c38108485c2f2
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
CppEditor: Simplify CppHoverHandler::identifyMatch 2017-10-25T06:20:15+00:00 Nikolai Kosjar nikolai.kosjar@qt.io 2017-10-23T13:53:57+00:00 9d1939799467ec900eee20b0c68b82d367aaaea7 Diagnostic tooltips for the built-in code model were determined with the help of editorWidget->extraSelectionTooltip(), which iterated over all extra selections. Rely on CppElementEvaluator::hasDiagnosis() instead, which looks only for the relevant selections of the category CodeWarningsSelection. This is not supposed to change any behavior. Change-Id: I7aea678b347a94a00610057180e305921234b580 Reviewed-by: David Schulz <david.schulz@qt.io> 
Diagnostic tooltips for the built-in code model were determined with the
help of editorWidget->extraSelectionTooltip(), which iterated over all
extra selections. Rely on CppElementEvaluator::hasDiagnosis() instead,
which looks only for the relevant selections of the category
CodeWarningsSelection.

This is not supposed to change any behavior.

Change-Id: I7aea678b347a94a00610057180e305921234b580
Reviewed-by: David Schulz <david.schulz@qt.io>
TextEditor: move convenience from texteditor to utils 2017-09-22T12:59:35+00:00 Ivan Donchevskii ivan.donchevskii@qt.io 2017-09-21T10:35:24+00:00 80a472740d62f0e0b1ffc177c75641691e99e213 Allows to use this header without texteditor dependency. Change-Id: I706f42799c3ea42473a716fa9ef9f3cfbef6fdd4 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io> 
Allows to use this header without texteditor dependency.

Change-Id: I706f42799c3ea42473a716fa9ef9f3cfbef6fdd4
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
TextEditor: Remove unneeded functions in BaseHoverHandler 2017-06-29T08:01:28+00:00 Nikolai Kosjar nikolai.kosjar@qt.io 2017-06-28T12:43:13+00:00 a7e8406ced48818682e52ca208af94c18c8c837e Change-Id: Ic61babb48cca0711812256b766f1db62895901f6 Reviewed-by: David Schulz <david.schulz@qt.io> 
Change-Id: Ic61babb48cca0711812256b766f1db62895901f6
Reviewed-by: David Schulz <david.schulz@qt.io>
Clang: Set help id for tooltip 2017-06-19T11:08:45+00:00 Nikolai Kosjar nikolai.kosjar@qt.io 2017-06-19T08:56:45+00:00 6bacfdac7cfd5e5453df622c77922bc9d494d725 ...so it can be cached. The base implementation does this, too. For certain uses cases, it will avoid a call to context->contextHelpId() in HelpPlugin::showContextHelp. Change-Id: Ia575595c6f723e3681d4685e2e1ce65b2e435ad1 Reviewed-by: Marco Bubke <marco.bubke@qt.io> 
...so it can be cached. The base implementation does this, too. For
certain uses cases, it will avoid a call to context->contextHelpId() in
HelpPlugin::showContextHelp.

Change-Id: Ia575595c6f723e3681d4685e2e1ce65b2e435ad1
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
CppEditor: Use full tooltip in ClangTextMark 2016-07-25T13:25:16+00:00 hjk hjk@theqtcompany.com 2016-07-22T06:57:32+00:00 728b9147279ee71a000be71d7dd95334f50aa8ae Change-Id: I39cc64acbdbcd5e5156e1514acaf9674a91e81a4 Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io> 
Change-Id: I39cc64acbdbcd5e5156e1514acaf9674a91e81a4
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Clang: Use CppHoverHandler for diagnostic tooltips 2016-02-12T11:20:27+00:00 Nikolai Kosjar nikolai.kosjar@theqtcompany.com 2016-01-27T12:37:19+00:00 9a4284d666a760960177cb42f6a2b78800f493a4 We used to call QTextCharFormat::setToolTip from the ExtraSelection to install the diagnostic tooltip. Since this allows to set only text tooltips and we would like to introduce a custom tooltip widget for diagnostics, make use of CppHoverHandler, which is more flexible. Change-Id: Ia1b2c3c50810596ce4a3a025002e6e4efd8789db Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com> 
We used to call QTextCharFormat::setToolTip from the ExtraSelection to
install the diagnostic tooltip. Since this allows to set only text
tooltips and we would like to introduce a custom tooltip widget for
diagnostics, make use of CppHoverHandler, which is more flexible.

Change-Id: Ia1b2c3c50810596ce4a3a025002e6e4efd8789db
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
CppEditor: Clean up CppHoverHandler 2016-02-09T09:07:48+00:00 Nikolai Kosjar nikolai.kosjar@theqtcompany.com 2016-01-27T11:51:07+00:00 c997e5e54c5db30b94f76a012984cc9fda250744 Change-Id: I1ac54206ca2735c55c1468ddd4ab5f3106665f16 Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com> Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com> 
Change-Id: I1ac54206ca2735c55c1468ddd4ab5f3106665f16
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>