From a3cb35edbebf35b0bc1a89c9e274b6c5c7b428a8 Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Tue, 11 Jun 2013 10:22:10 +0200 Subject: C++: Handle recursive using/typedef declarations Remember using/typedef declarations we have already looked up and stop if we try it again. Change-Id: I91bf0aef4df18539a47d015f0113543aef1f692a Reviewed-by: Erik Verbruggen (cherry picked from commit 50a900e509be2e1f448f29be126ba3b7f8173901) --- src/plugins/cpptools/cppcompletion_test.cpp | 137 ++++++++++++++++++++++++++++ 1 file changed, 137 insertions(+) (limited to 'src/plugins/cpptools/cppcompletion_test.cpp') diff --git a/src/plugins/cpptools/cppcompletion_test.cpp b/src/plugins/cpptools/cppcompletion_test.cpp index 44f9178cdb..0be0fa1b53 100644 --- a/src/plugins/cpptools/cppcompletion_test.cpp +++ b/src/plugins/cpptools/cppcompletion_test.cpp @@ -1885,3 +1885,140 @@ void CppToolsPlugin::test_completion_recursive_auto_declarations2_QTCREATORBUG95 QCOMPARE(completions.size(), 0); } + +void CppToolsPlugin::test_completion_recursive_typedefs_declarations1() +{ + TestData data; + data.srcText = + "void f()\n" + "{\n" + " typedef A B;\n" + " typedef B A;\n" + " A a;\n" + " @;\n" + " // padding so we get the scope right\n" + "}\n" + ; + setup(&data); + + Utils::ChangeSet change; + QString txt = QLatin1String("a."); + change.insert(data.pos, txt); + QTextCursor cursor(data.doc); + change.apply(&cursor); + data.pos += txt.length(); + + QStringList completions = getCompletions(data); + + QCOMPARE(completions.size(), 0); +} + +void CppToolsPlugin::test_completion_recursive_typedefs_declarations2() +{ + TestData data; + data.srcText = + "void f()\n" + "{\n" + " typedef A C;\n" + " typedef C B;\n" + " typedef B A;\n" + " A a;\n" + " @;\n" + " // padding so we get the scope right\n" + "}\n" + ; + setup(&data); + + Utils::ChangeSet change; + QString txt = QLatin1String("a."); + change.insert(data.pos, txt); + QTextCursor cursor(data.doc); + change.apply(&cursor); + data.pos += txt.length(); + + QStringList completions = getCompletions(data); + + QCOMPARE(completions.size(), 0); +} + +void CppToolsPlugin::test_completion_recursive_using_declarations1() +{ + TestData data; + data.srcText = + "void f()\n" + "{\n" + " using B = A;\n" + " using A = B;\n" + " A a;\n" + " @;\n" + " // padding so we get the scope right\n" + "}\n" + ; + setup(&data); + + Utils::ChangeSet change; + QString txt = QLatin1String("a."); + change.insert(data.pos, txt); + QTextCursor cursor(data.doc); + change.apply(&cursor); + data.pos += txt.length(); + + QStringList completions = getCompletions(data); + + QCOMPARE(completions.size(), 0); +} + +void CppToolsPlugin::test_completion_recursive_using_declarations2() +{ + TestData data; + data.srcText = + "void f()\n" + "{\n" + " using C = A;\n" + " using B = C;\n" + " using A = B;\n" + " A a;\n" + " @;\n" + " // padding so we get the scope right\n" + "}\n" + ; + setup(&data); + + Utils::ChangeSet change; + QString txt = QLatin1String("a."); + change.insert(data.pos, txt); + QTextCursor cursor(data.doc); + change.apply(&cursor); + data.pos += txt.length(); + + QStringList completions = getCompletions(data); + + QCOMPARE(completions.size(), 0); +} + +void CppToolsPlugin::test_completion_recursive_using_typedef_declarations() +{ + TestData data; + data.srcText = + "void f()\n" + "{\n" + " using B = A;\n" + " typedef B A;\n" + " A a;\n" + " @;\n" + " // padding so we get the scope right\n" + "}\n" + ; + setup(&data); + + Utils::ChangeSet change; + QString txt = QLatin1String("a."); + change.insert(data.pos, txt); + QTextCursor cursor(data.doc); + change.apply(&cursor); + data.pos += txt.length(); + + QStringList completions = getCompletions(data); + + QCOMPARE(completions.size(), 0); +} -- cgit v1.2.1