From 7ab6783e24c6a05a67f319817cd1bdd026a7ce43 Mon Sep 17 00:00:00 2001 From: hjk Date: Wed, 24 Jul 2019 18:40:10 +0200 Subject: Standardize on int for line and column values Recently tons of warnings show up for presumably "problematic" singned <-> unsigned and size conversions. The Qt side uses 'int', and that's the biggest 'integration surface' for us, so instead of establishing some internal boundary between signed and unsigned areas, push that boundary out of creator core code, and use 'int' everywhere. Because it reduces friction further, also do it in libcplusplus. Change-Id: I84f3b79852c8029713e7ea6f133ffb9ef7030a70 Reviewed-by: Nikolai Kosjar --- src/plugins/cpptools/cppsourceprocessor_test.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/plugins/cpptools/cppsourceprocessor_test.cpp') diff --git a/src/plugins/cpptools/cppsourceprocessor_test.cpp b/src/plugins/cpptools/cppsourceprocessor_test.cpp index 009264cc3c..67a1b9f702 100644 --- a/src/plugins/cpptools/cppsourceprocessor_test.cpp +++ b/src/plugins/cpptools/cppsourceprocessor_test.cpp @@ -179,11 +179,11 @@ void CppToolsPlugin::test_cppsourceprocessor_macroUses() const QList macroUses = document->macroUses(); QCOMPARE(macroUses.size(), 1); const Document::MacroUse macroUse = macroUses.at(0); - QCOMPARE(macroUse.bytesBegin(), 25U); - QCOMPARE(macroUse.bytesEnd(), 35U); - QCOMPARE(macroUse.utf16charsBegin(), 25U); - QCOMPARE(macroUse.utf16charsEnd(), 35U); - QCOMPARE(macroUse.beginLine(), 2U); + QCOMPARE(macroUse.bytesBegin(), 25); + QCOMPARE(macroUse.bytesEnd(), 35); + QCOMPARE(macroUse.utf16charsBegin(), 25); + QCOMPARE(macroUse.utf16charsEnd(), 35); + QCOMPARE(macroUse.beginLine(), 2); } static bool isMacroDefinedInDocument(const QByteArray ¯oName, const Document::Ptr &document) -- cgit v1.2.1