From d0e5facb0e09da01fb00c30ac712c740359d3cae Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Thu, 11 Jul 2013 12:37:44 +0200 Subject: CppTools: Tests: Clean up cppmodelmanager_test.cpp * First construct a ProjectPart completely, then append it to the ProjectInfo. Doing it the other way around will lead to inconsistencies since some attributes of ProjectInfo are calculated/updated when a ProjectPart is appended. This has no effect on the current tests. * Remove created *.user file when test finishes. * Add comments describing what the tests do. * Rename test methods to some more desribtive names. Change-Id: I5eeed05d0aef19f8094ff488dedcced74f0814f8 Reviewed-by: Erik Verbruggen --- src/plugins/cpptools/cpptoolsplugin.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/plugins/cpptools/cpptoolsplugin.h') diff --git a/src/plugins/cpptools/cpptoolsplugin.h b/src/plugins/cpptools/cpptoolsplugin.h index 09bea7fc3c..902b5908fb 100644 --- a/src/plugins/cpptools/cpptoolsplugin.h +++ b/src/plugins/cpptools/cpptoolsplugin.h @@ -159,10 +159,10 @@ private slots: void test_format_pointerdeclaration_macros(); void test_format_pointerdeclaration_macros_data(); - void test_modelmanager_paths(); + void test_modelmanager_paths_are_clean(); void test_modelmanager_framework_headers(); - void test_modelmanager_refresh_1(); - void test_modelmanager_refresh_2(); + void test_modelmanager_refresh_also_includes_of_project_files(); + void test_modelmanager_refresh_several_times(); void test_modelmanager_snapshot_after_two_projects(); void test_modelmanager_extraeditorsupport_uiFiles(); -- cgit v1.2.1 From 072b7c571846c187daf79e779b64557ca8b065b8 Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Tue, 16 Jul 2013 12:08:39 +0200 Subject: CppTools: Check if project has changed before reparsing This introduces an API change for the project managers. Those are not expected to call updateSourceFiles() anymore. Task-number: QTCREATORBUG-9581 Change-Id: I77befd29fb851c9acf87204d571da00183c9cd05 Reviewed-by: Erik Verbruggen --- src/plugins/cpptools/cpptoolsplugin.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/plugins/cpptools/cpptoolsplugin.h') diff --git a/src/plugins/cpptools/cpptoolsplugin.h b/src/plugins/cpptools/cpptoolsplugin.h index 902b5908fb..5283c1dd83 100644 --- a/src/plugins/cpptools/cpptoolsplugin.h +++ b/src/plugins/cpptools/cpptoolsplugin.h @@ -163,6 +163,7 @@ private slots: void test_modelmanager_framework_headers(); void test_modelmanager_refresh_also_includes_of_project_files(); void test_modelmanager_refresh_several_times(); + void test_modelmanager_refresh_test_for_changes(); void test_modelmanager_snapshot_after_two_projects(); void test_modelmanager_extraeditorsupport_uiFiles(); -- cgit v1.2.1