From b6a996a8d5c9246ca41b15aaba7c527df2872513 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 6 Dec 2021 15:42:25 +0100 Subject: DiffEditor: Assert that we are operating on non-null documents Task-number: QTCREATORBUG-26594 Change-Id: I4331c457a6360682229dbbbfd8ac3d50b44b8ead Reviewed-by: Reviewed-by: Christian Stenger --- src/plugins/diffeditor/diffeditorplugin.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/plugins/diffeditor/diffeditorplugin.cpp') diff --git a/src/plugins/diffeditor/diffeditorplugin.cpp b/src/plugins/diffeditor/diffeditorplugin.cpp index 624de7002b..69863f9120 100644 --- a/src/plugins/diffeditor/diffeditorplugin.cpp +++ b/src/plugins/diffeditor/diffeditorplugin.cpp @@ -254,6 +254,7 @@ QList DiffOpenFilesController::reloadInputList() const const QList openedDocuments = DocumentModel::openedDocuments(); for (IDocument *doc : openedDocuments) { + QTC_ASSERT(doc, continue); auto textDocument = qobject_cast(doc); if (textDocument && textDocument->isModified()) { @@ -518,6 +519,7 @@ void DiffEditorPluginPrivate::updateDiffCurrentFileAction() void DiffEditorPluginPrivate::updateDiffOpenFilesAction() { const bool enabled = Utils::anyOf(DocumentModel::openedDocuments(), [](IDocument *doc) { + QTC_ASSERT(doc, return false); return doc->isModified() && qobject_cast(doc); }); m_diffOpenFilesAction->setEnabled(enabled); -- cgit v1.2.1