From 7b08d993bff0951428d6a7cb2d402e9571df0550 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Sun, 6 Oct 2013 20:47:29 +0300 Subject: VCS: Pass workingDirectory for annotate Required for supporting renames on annotate. The renamed file (and possibly its parent directory) doesn't exist anymore, so it shouldn't be passed as a working directory. Change-Id: I809e8df17c1dc5199e533b525244a668eccbcd5f Reviewed-by: Tobias Hunger --- src/plugins/git/gitclient.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/plugins/git/gitclient.cpp') diff --git a/src/plugins/git/gitclient.cpp b/src/plugins/git/gitclient.cpp index 87fb48d6f3..bd6327ec92 100644 --- a/src/plugins/git/gitclient.cpp +++ b/src/plugins/git/gitclient.cpp @@ -1038,8 +1038,8 @@ VcsBase::VcsBaseEditorWidget *GitClient::createVcsEditor( m_msgWait.toUtf8()); outputEditor->document()->setProperty(registerDynamicProperty, dynamicPropertyValue); rc = VcsBase::VcsBaseEditorWidget::getVcsBaseEditor(outputEditor); - connect(rc, SIGNAL(annotateRevisionRequested(QString,QString,int)), - this, SLOT(slotBlameRevisionRequested(QString,QString,int))); + connect(rc, SIGNAL(annotateRevisionRequested(QString,QString,QString,int)), + this, SLOT(slotBlameRevisionRequested(QString,QString,QString,int))); QTC_ASSERT(rc, return 0); rc->setSource(source); if (codecType == CodecSource) { @@ -1461,15 +1461,15 @@ void GitClient::saveSettings() settings()->writeSettings(Core::ICore::settings()); } -void GitClient::slotBlameRevisionRequested(const QString &source, QString change, int lineNumber) +void GitClient::slotBlameRevisionRequested(const QString &workingDirectory, const QString &file, + QString change, int lineNumber) { // This might be invoked with a verbose revision description // "SHA1 author subject" from the annotation context menu. Strip the rest. const int blankPos = change.indexOf(QLatin1Char(' ')); if (blankPos != -1) change.truncate(blankPos); - const QFileInfo fi(source); - blame(fi.absolutePath(), QStringList(), fi.fileName(), change, lineNumber); + blame(workingDirectory, QStringList(), file, change, lineNumber); } QTextCodec *GitClient::getSourceCodec(const QString &file) const -- cgit v1.2.1