From fe7d6f0defbfb287e6bb2205aa446965d731672c Mon Sep 17 00:00:00 2001 From: hjk Date: Fri, 28 May 2021 14:48:25 +0200 Subject: Utils: Drop QProcess specific parameters from QtcProcess::finished() Mid-term plan is to concentrate on use of QtcProcess::result() instead which is a bit more system-agnostic. There's quite a bit of potential for downstream cleanup by re-using QtcProcess::exitMessage() now. Change-Id: I3806b3f5933d96e64b7cfb18cc6c52823fddcbcd Reviewed-by: Christian Stenger --- src/plugins/python/pythonutils.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src/plugins/python/pythonutils.cpp') diff --git a/src/plugins/python/pythonutils.cpp b/src/plugins/python/pythonutils.cpp index 8744502c82..af1c42b5ab 100644 --- a/src/plugins/python/pythonutils.cpp +++ b/src/plugins/python/pythonutils.cpp @@ -292,15 +292,16 @@ private: .arg(m_killTimer.isActive() ? tr("user") : tr("time out"))); } - void installFinished(int exitCode, QProcess::ExitStatus exitStatus) + void installFinished() { m_future.reportFinished(); - if (exitStatus == QProcess::NormalExit && exitCode == 0) { + if (m_process.result() == QtcProcess::FinishedWithSuccess) { if (Client *client = registerLanguageServer(m_python)) LanguageClientManager::openDocumentWithClient(m_document, client); } else { Core::MessageManager::writeFlashing( - tr("Installing the Python language server failed with exit code %1").arg(exitCode)); + tr("Installing the Python language server failed with exit code %1") + .arg(m_process.exitCode())); } deleteLater(); } -- cgit v1.2.1