diff options
| author | Robert Griebl <robert.griebl@qt.io> | 2021-11-30 14:40:23 +0100 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-12-01 00:29:13 +0000 |
| commit | 6f18214c92408d1e77ac6bf89128b7ae993d344f (patch) | |
| tree | 53eaff321626564244614ea29d16cd3b8b0c30fd | |
| parent | 841b21a28aad4c0ae8a5a37ac7b3282d34b56f9a (diff) | |
| download | qtapplicationmanager-6f18214c92408d1e77ac6bf89128b7ae993d344f.tar.gz | |
Fix glibc compatibility problem
glibc 2.32 deprecated sys_siglist: the symbol is not available to link
against anymore, but it is available at runtime for apps that have been
linked against an older glibc version.
Our problem is now that the CI builds release version of the AM against
an older glibc, which works for the appman binary itself, but if you
want to compile a custom appman executable on a modern, glibc 2.32
based system, you get a "missing symbol" linker error in
libQt6AppManCommon.a(unixsignalhandler.cpp.o)
Detecting this at runtime would be a nightmare for little gain, so we
fall back to using the non-async-signal-safe strsignal() function
when initially building against a glibc < 2.32.
Change-Id: I1e702c5ee00e2725fe6f76f9ce001c099ec72eea
Fixes: AUTOSUITE-1667
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
(cherry picked from commit 65ddbe72001cc9e5a49b54d821eafd352c25ee92)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | src/common-lib/unixsignalhandler.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/common-lib/unixsignalhandler.cpp b/src/common-lib/unixsignalhandler.cpp index 74616950..d74e5e44 100644 --- a/src/common-lib/unixsignalhandler.cpp +++ b/src/common-lib/unixsignalhandler.cpp @@ -103,7 +103,7 @@ const char *UnixSignalHandler::signalName(int sig) #if __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 32 return sigdescr_np(sig); #else - return sys_siglist[sig]; + return strsignal(sig); // not async-signal-safe #endif #else Q_UNUSED(sig) |