diff options
| author | Robert Griebl <robert.griebl@qt.io> | 2022-10-11 18:25:05 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2022-10-12 11:09:50 +0000 |
| commit | f821b902abe957ea94690b4b22f2211e3511d83c (patch) | |
| tree | a88fdcbd5c1387a0b871851d5494a9cea1a837dd | |
| parent | 5f5ab621539de1675c922e95da01fc30545f01b3 (diff) | |
| download | qtapplicationmanager-f821b902abe957ea94690b4b22f2211e3511d83c.tar.gz | |
Fix a potential crash when trying to start applications
If you were calling startApplication() and the runtime failed to
execute the app's binary in a container, it would call deleteLater() on
the failed runtime object. The problem was that if you immediately
called startApplication() once more in the same event loop iteration,
the Application object still had the to-be-deleted runtime attached,
which in turn prevents the allocation of a new container, so the
AM tried to start the application again, but this time with
"container" set to nullptr.
The actual fix is to NOT call deleteLater, but directly delete the
runtime object.
In addition, when startApplication() is called for an application,
we have to make sure that the application's runtime object can not
be in the state NotRunning: the AM could still end up in this state,
if a Container plugin is either not reporting shutdown correctly, or
if the container's "ready" state is delayed.
Change-Id: Ied1baec8c90d4e0a980c296cbc7cd87b12629524
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
(cherry picked from commit 5ae261864728678df3dd72f156efc6688dcf695d)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | src/manager-lib/applicationmanager.cpp | 14 | ||||
| -rw-r--r-- | src/manager-lib/nativeruntime.cpp | 4 |
2 files changed, 10 insertions, 8 deletions
diff --git a/src/manager-lib/applicationmanager.cpp b/src/manager-lib/applicationmanager.cpp index 6437140d..5e3a8cf4 100644 --- a/src/manager-lib/applicationmanager.cpp +++ b/src/manager-lib/applicationmanager.cpp @@ -696,6 +696,8 @@ bool ApplicationManager::startApplicationInternal(const QString &appId, const QS return false; case Am::NotRunning: + throw Exception("Application %1 is not running, but still has a Runtime object attached") + .arg(app->id()); break; } } @@ -817,12 +819,14 @@ bool ApplicationManager::startApplicationInternal(const QString &appId, const QS qCDebug(LogSystem) << " documentUrl:" << documentUrl; if (inProcess) { - bool ok = runtime->start(); - if (ok) + bool successfullyStarted = runtime->start(); + + if (successfullyStarted) emitActivated(app); else - runtime->deleteLater(); - return ok; + delete runtime; + + return successfullyStarted; } else { // We can only start the app when both the container and the windowmanager are ready. // Using a state-machine would be one option, but then we would need that state-machine @@ -834,7 +838,7 @@ bool ApplicationManager::startApplicationInternal(const QString &appId, const QS if (successfullyStarted) emitActivated(app); else - runtime->deleteLater(); // ~Runtime() will clean app->nonAliased()->m_runtime + delete runtime; // ~Runtime() will clean up app->m_runtime return successfullyStarted; }; diff --git a/src/manager-lib/nativeruntime.cpp b/src/manager-lib/nativeruntime.cpp index 19c65666..f9ed8447 100644 --- a/src/manager-lib/nativeruntime.cpp +++ b/src/manager-lib/nativeruntime.cpp @@ -180,9 +180,7 @@ bool NativeRuntime::attachApplicationToQuickLauncher(Application *app) ret = startApplicationViaLauncher(); } - if (ret) - setState(Am::Running); - + setState(ret ? Am::Running : Am::NotRunning); return ret; } |