From e5bdbb08eb75d3ed9b0a55932273230221b2f0a4 Mon Sep 17 00:00:00 2001 From: Robert Griebl Date: Thu, 24 Mar 2022 12:53:38 +0100 Subject: Really fix package removal if documentDir is not set The fix in bc06a04dd845d039ba802f94b5eae57519ec63a8 was not correct in the package removal case. Change-Id: I65645a1895b6e5cba6dfa6bd61be1b1a638fe67a Reviewed-by: Bernd Weimer (cherry picked from commit 074d1a70d273b72a369009a6105a7dcad2efc48b) Reviewed-by: Qt Cherry-pick Bot --- src/manager-lib/deinstallationtask.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/manager-lib/deinstallationtask.cpp b/src/manager-lib/deinstallationtask.cpp index 4de582a1..23bc0204 100644 --- a/src/manager-lib/deinstallationtask.cpp +++ b/src/manager-lib/deinstallationtask.cpp @@ -114,7 +114,7 @@ void DeinstallationTask::execute() ScopedRenamer docDirRename; ScopedRenamer appDirRename; - if (!m_keepDocuments || !m_documentPath.isEmpty()) { + if (!m_keepDocuments && !m_documentPath.isEmpty()) { if (!docDirRename.rename(QDir(m_documentPath).absoluteFilePath(packageId()), ScopedRenamer::NameToNameMinus)) { throw Exception(Error::IO, "could not rename %1 to %1-").arg(docDirRename.baseName()); -- cgit v1.2.1