diff options
author | Gunnar Sletta <gunnar@sletta.org> | 2015-08-14 12:38:39 +0200 |
---|---|---|
committer | Gunnar Sletta <gunnar@sletta.org> | 2015-08-17 09:37:57 +0000 |
commit | 59a0e6f0b7e7c345b0328d9d66e503cfb1f94ebe (patch) | |
tree | a57bb4ddd2243df0691819a36b69bd11e6dfc6e2 | |
parent | 3cfe3215e0382565805c35806a288331ba3ebffb (diff) | |
download | qtgraphicaleffects-59a0e6f0b7e7c345b0328d9d66e503cfb1f94ebe.tar.gz |
Change the default DropShadow offset back to 0.
Though this makes DropShadows work out of the box and
be less confusing to users, it also ends up breaking code
that uses DropShadow as a glow effect.
Change-Id: Id65dc85d2877709f3bd8d036f06c7b8fc2886777
Task-number: QTBUG-47749
Reviewed-by: Mitch Curtis <mitch.curtis@theqtcompany.com>
-rw-r--r-- | src/effects/private/DropShadowBase.qml | 4 | ||||
-rw-r--r-- | tests/auto/tst_qtgraphicaleffects.cpp | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/effects/private/DropShadowBase.qml b/src/effects/private/DropShadowBase.qml index 3c2d8d8..8cc259c 100644 --- a/src/effects/private/DropShadowBase.qml +++ b/src/effects/private/DropShadowBase.qml @@ -49,8 +49,8 @@ Item { property int radius: samples / 2 property int samples: 9 property color color: "black" - property int horizontalOffset: 10 - property int verticalOffset: 10 + property int horizontalOffset: 0 + property int verticalOffset: 0 property real spread: 0.0 property bool cached: false property bool transparentBorder: true diff --git a/tests/auto/tst_qtgraphicaleffects.cpp b/tests/auto/tst_qtgraphicaleffects.cpp index 01a4bc5..c676b9c 100644 --- a/tests/auto/tst_qtgraphicaleffects.cpp +++ b/tests/auto/tst_qtgraphicaleffects.cpp @@ -437,8 +437,8 @@ void tst_qtgraphicaleffects::dropShadow() // Default values QCOMPARE(obj->property("radius").toDouble(), 4.0); QCOMPARE(obj->property("samples").toInt(), 9); - QCOMPARE(obj->property("horizontalOffset").toDouble(), 10.0); - QCOMPARE(obj->property("verticalOffset").toDouble(), 10.0); + QCOMPARE(obj->property("horizontalOffset").toDouble(), 0.0); + QCOMPARE(obj->property("verticalOffset").toDouble(), 0.0); QCOMPARE(obj->property("cached").toBool(), false); QCOMPARE(obj->property("source").toInt(), 0); QCOMPARE(obj->property("color").toString(), QString("#000000")); |