summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMoody Liu <mooodyhunter@outlook.com>2022-06-17 23:21:45 +0100
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2022-06-20 12:53:53 +0000
commitcd7e3c7b5e12cea497317e9b3de19294cbf68312 (patch)
tree6763b9f6dc7b277f4ce7dee9458b8133b94d0648
parentee277e5ea81b9648a6711fdc4be145af55832060 (diff)
downloadqtimageformats-cd7e3c7b5e12cea497317e9b3de19294cbf68312.tar.gz
jp2: use correct buffer_size for jas_stream_memopen
According to jasper's documentation, the second argument should be 0 instead of -1, to acquire such a dynamically growing buffer. This also causes a runtime crash due to the signedness of size_t. Fixes: QTBUG-104398 Change-Id: I173c6b7c9802c22fe0fa01083a71bf3b6ca7b134 Reviewed-by: Liang Qi <liang.qi@qt.io> (cherry picked from commit ad2e721683b7c68748b05862fe8cf33bf63ebf55) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
-rw-r--r--src/plugins/imageformats/jp2/qjp2handler.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/imageformats/jp2/qjp2handler.cpp b/src/plugins/imageformats/jp2/qjp2handler.cpp
index adc2891..e2a8c0b 100644
--- a/src/plugins/imageformats/jp2/qjp2handler.cpp
+++ b/src/plugins/imageformats/jp2/qjp2handler.cpp
@@ -853,7 +853,7 @@ bool Jpeg2000JasperReader::write(const QImage &image, int quality)
}
// Open an empty jasper stream that grows automatically
- jas_stream_t * memory_stream = jas_stream_memopen(0, -1);
+ jas_stream_t * memory_stream = jas_stream_memopen(0, 0);
// Jasper wants a non-const string.
char *str = qstrdup(jasperFormatString.toLatin1().constData());