summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Update dependencies on '6.4.2' in qt/qtmultimediav6.4.26.4.2Qt Submodule Update Bot2022-12-121-4/+4
| | | | | Change-Id: Ia800bcde9168f7d9807102d3dcff74bc0ccd5699 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on '6.4.2' in qt/qtmultimediaQt Submodule Update Bot2022-12-091-4/+4
| | | | | Change-Id: Ifd784a22670eb6e6d62ea1ff74e1b190cbc740d7 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on '6.4.2' in qt/qtmultimediaQt Submodule Update Bot2022-12-071-4/+4
| | | | | Change-Id: Ie1455b7034343953e5b027dd08fc3a600bc8320c Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Docs: fix links on multimediaoverview.htmlNicholas Bennett2022-12-051-2/+2
| | | | | | | | | | The reference documentation links were missing the \l command, this has been added. Change-Id: I7b340bc87302bd0179c6d9d79a15d09f3edcf708 Reviewed-by: Paul Wicking <paul.wicking@qt.io> (cherry picked from commit 28faab38a2acf323d6803ea2c0aed3d73cffb6b4) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update dependencies on '6.4.2' in qt/qtmultimediaQt Submodule Update Bot2022-12-051-4/+4
| | | | | Change-Id: I4b16c7f4bbb5bd9981c3f3b1e41314d3adeae23f Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix ffmpeg camera crash when videotoolbox doesn't support formatArtem Dyomin2022-12-013-14/+30
| | | | | | | | | | | | | | | | The change just fixes the crash: hw accel is not valid if videotoolbox doesn't support core format (e.g. 'yuvs', 'yuvf'). Ffmpeg camera still doesn't work with these core formats, it's to be fixed under the bug QTBUG-109009 (most likely, on ffmpeg library side). The issue is reproduced with pretty old cameras, e.g. on macbook pro 2015 year. Fixes: QTBUG-109009 Change-Id: Ib36a7e6b3b8c71fa1a3a2717c3509ca30d3b5caa Reviewed-by: Doris Verria <doris.verria@qt.io> (cherry picked from commit 1fc49f0c2ff603c39ba9d1dd90f0e621a0fde488)
* Update dependencies on '6.4' in qt/qtmultimediaQt Submodule Update Bot2022-12-011-4/+4
| | | | | Change-Id: I9b32ef8dc260085f3bd6a737cfb336fe98855e98 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix see-also syntax, silence qdoc warningVolker Hilsheimer2022-11-301-1/+1
| | | | | | | | | | | | | | qdoc informed us that it can't link to space-less 'QAudioSink,QAudioSource,QAudioFormat' because there is no such thing. Insert space after comma to fix the links and silence qdoc. Change-Id: I192a73753e2885ffc7e05a94b6fc0a9ac91f13b8 Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io> (cherry picked from commit e9dc2e079a5fdde2af37896d6cf7f35ab6bc89d4) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix ffmpeg camera crash on macOS (double releasing of an object)Artem Dyomin2022-11-303-2/+35
| | | | | | | | | | | | | | | The reason for the crash is 'autorelease' and 'release' in the destructor. In applications, QMacAutoReleasePool releases it 2nd time. The application crashed after a few camera changes. So we should use only one approach. The suggestion is to manage the object manually for both backends in order to make the behavior more predictable. The added test checks the case. Change-Id: I80a644acd94ae469a16fd95ba971441c78e7a700 Reviewed-by: Doris Verria <doris.verria@qt.io> (cherry picked from commit d73cc0bce893b81de3f84c570110c8969b9ee468) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update dependencies on '6.4' in qt/qtmultimediaQt Submodule Update Bot2022-11-291-3/+3
| | | | | Change-Id: I8a4746ad999d3cbd7130eb592be3887037379b0f Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix typo: to setup -> to set upPiotr Srebrny2022-11-288-10/+10
| | | | | | Change-Id: Ia9c8964ce8671fcf384c5590b4fcb804a3e42915 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit 5a0b6bee16c9b71589209e6aa18a77c987d27800)
* QWindowsMediaDevices: Fix potential null-pointer-accessVladimir Belyavsky2022-11-271-4/+5
| | | | | | | | | | It seems sometimes IMMDeviceEnumerator::GetDefaultAudioEndpoint() may return null device even when succeeded. It's probably a bug in MS Core Audio. So we'll check this explicitly to prevent null-pointer-access. Fixes: QTBUG-108898 Change-Id: Iba1e6673f12a3dafd80f3de11e40babeb1e21e35 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit 9f7eb2bacee57bf95f975f97d72e98d9ca19714e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix some memory leaks and crashes in corner cases with ffmpeg encoderArtem Dyomin2022-11-239-103/+105
| | | | | | | | | | | | | Refactoring: use unique_ptr for managing avframes. Memory leaks occurred because of inaccurate avframe memory management Crashes occurred on linux with some virtual cameras because of null pix_fmts and null codecContext. Change-Id: I8ad0b922e89cf01bc79eba6cbbfeb9d6172b9d56 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit 9242a5262a32d793deb5c4d745546fab8dd8d165) Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Android: Fix for QAndroidMediaPlayer isSeekable methodBartlomiej Moskal2022-11-232-7/+2
| | | | | | | | | | | | | | | | | isSeekable() method should return correct value. It seem that m_seekable is corretly set in Base class. That is why we shouldn't override isSeekable method in our implementation. Additionally, after commit 0de7ff081f6d75122d2186d399a6f06cd865978e, default m_seekable value was changed to false which is not the correct approach on Android. Value need to be set to true in QAndroidMediaPlayer constructor. It changes if MEDIA_INFO_NOT_SEEKABLE is received. Task-number: QTBUG-103567 Change-Id: I662e12610ea76472bfde408ba8a1dac602b63788 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io> (cherry picked from commit d986272abe0e78aa4fecd2c385f880fd28ec336b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update dependencies on '6.4' in qt/qtmultimediaQt Submodule Update Bot2022-11-231-2/+2
| | | | | Change-Id: I434db84cfb8aefc66d5b95aa1182fdf3c1fb8b41 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update dependencies on '6.4' in qt/qtmultimediaQt Submodule Update Bot2022-11-221-4/+4
| | | | | Change-Id: Ib1a8cda0762e4a215cc3cbd091233f9957403b03 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Port from qAsConst() to std::as_const()Marc Mutz2022-11-1814-33/+33
| | | | | | | | | | | | | | | | We've been requiring C++17 since Qt 6.0, and our qAsConst use finally starts to bother us (QTBUG-99313), so time to port away from it now. Since qAsConst has exactly the same semantics as std::as_const (down to rvalue treatment, constexpr'ness and noexcept'ness), there's really nothing more to it than a global search-and-replace. This is a 6.4 re-run of the script we ran in dev, in order to avoid conflicts between the branches when cherry-picking. Change-Id: I5eca3df3179dfb2b2682c75a479ba9a4259cc703 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Port from container::count() and length() to size() - V5Marc Mutz2022-11-1820-353/+353
| | | | | | | | | | This is a the same semantic patch (qt-port-to-std-compatible-api V5 with config Scope: 'Container') as in dev. I've re-ran it in 6.4 to avoid cherry-pick conflicts. Change-Id: I9621dee5ed328b47e78919a34c307105e4311903 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Update dependencies on '6.4' in qt/qtmultimediaQt Submodule Update Bot2022-11-181-4/+4
| | | | | Change-Id: I14ad7cd0885f518e3ca8bf1f6f455a67a03297f6 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix camera ffmpeg crashArtem Dyomin2022-11-161-1/+7
| | | | | | | | | | The commit just fixes typo made in one of recent commits. Tests on local PC get passed after the fix. Change-Id: I4e4adf5f0f039867f0ecad5130e072169ab91eac Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit be49af3b0f062fceef31711c67450ffbf595a808) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update dependencies on '6.4' in qt/qtmultimediaQt Submodule Update Bot2022-11-141-4/+4
| | | | | Change-Id: I35a7af9482a60edaff3aeb56948d70c11b6e0e6c Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix 'unsigned int' and 'qsizetype' comparison warnigns for Android armv7Assam Boudjelthia2022-11-141-2/+2
| | | | | | | | | | Comparison of integers of different signs: 'unsigned int' and 'qsizetype' (aka 'int') Change-Id: I1bab2180b2e0b632ffb454b9d8b95c6d5116f8c3 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit 55f71b9d321aed3f7e0df0cb9c750152a4ab9aff) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix crash on macos13 with iphone cameraArtem Dyomin2022-11-141-26/+51
| | | | | | | | | | | | | | | | | | | | | | | | On macos13 new feature has been introduced: possibility using a camera of paired iphone on macos. The feature works but it's a bit buggy: AVCaptureDevice.hasFlash is true but none of flash modes is supported. Setting of not supported flash mode causes exception. The exeptions happens when setting AVCaptureFlashModeOff, but, in theory, it can occur in other corner cases. Documentation recommentds to check if flash mode supported in order to avoid exceptions. So, what's done: - checking of supported flash and torch modes before setting - use captureDevice.isFlashAvailable not only for mac os since ios camera can be paired Task-number: QTBUG-108018 Change-Id: I42772edb4c26481283d1bd321914bf40284efde9 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit 7d9713412ba3db914f984be16aeba6be820d68a4)
* Bump version to 6.4.2Jani Heikkinen2022-11-111-1/+1
| | | | | Change-Id: I2d5090aed9f042cff96744a111360cfc1b75b719 Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
* Update dependencies on '6.4' in qt/qtmultimediaQt Submodule Update Bot2022-11-111-4/+4
| | | | | Change-Id: Ice8b137e1bf47158ad15b013a304fbc76f80bf2c Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix issues in camera exampleArtem Dyomin2022-11-112-21/+22
| | | | | | | | | | - fix memory leak - QImageCapture - fix multimple signals connection Change-Id: I63df2bd16f678c67a3ee90c7e7251575d9cdeb1e Reviewed-by: Piotr Srebrny <piotr.srebrny@qt.io> Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit ac0e44288d305fb22d9396f97f7ee0b1d371e917)
* Add parent-child relationship on audio sources and sinksPiotr Srebrny2022-11-1153-134/+197
| | | | | | | | | | | | | | QAudioSink and QAudioSource must propagate their parents to the platform specific implementation to enable correct operation of the moveToThread function. Furthermore, all QObject elements that are owned by audio sink/source must also establish the parent-child relationship. This mainly affects QTimer's used by the audio sink/sources. Fixes: QTBUG-108187 Change-Id: I476a97300a6fb1e0022b2a5570a3803be8fd0a88 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit 7c55a711cf5153d5b0a7e2318314cbe0c1e42361)
* Look up device classes in an order independent wayPiotr Srebrny2022-11-111-6/+2
| | | | | | | | | | | | | GStreamer does not guarantee any specific order in the class list returned by gst_device_get_device_class. Instead of using strcmp on this list we can check device classes in the order independet way using gst_device_has_classes. Fixes: QTBUG-107671 Change-Id: If43781f39cd229ba9b0d9eefebd687017ba9e952 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit 79267f7d3da56a4907d6ff9f2ddfdb2d296a47d1) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix ffmpeg compilation and tests on win CIArtem Dyomin2022-11-091-2/+1
| | | | | | | | | | | | | | | | - fix unused variables - fix screen capture crash - related commit in qt5 fixes ffmpeg build on CI Currently, the build works with msvc and mingw, llvm should be added in the next commits. See build example: https://testresults.qt.io/coin/integration/qt/qtmultimedia/tasks/web_qt_qtmultimedia_1667916985085 Change-Id: Ibd27c7520a00899c893a842eef55fa4f30eba948 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit 0c2576112d98d5fcadbfb2ee9f407bbc9ad72d85)
* Ensure height is even as we write two lines at oncePiotr Srebrny2022-11-091-0/+2
| | | | | | | | Fixes: QTBUG-103238 Change-Id: I50b0bd74760c8b6f35e307e1580fc3ea7b57cd0d Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit c67855345475fd293e9a2a6921328e356f881d06) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add audio listeners for macOS and cleanup codeArtem Dyomin2022-11-074-108/+188
| | | | | | | | | | | | | | | | | | | | | | QMediaDevices doc says: The default device can change during the runtime of the application. The audioInputsChanged/audioOutputsChanged signal is emitted in this case. What's done: - add listening of properties kAudioHardwarePropertyDefaultOutputDevice and kAudioHardwarePropertyDefaultInputDevice in order to handle default input/output changes. - cleanup a mess of defines in qdarwinmediadevices.mm - some refactoring with code improving. Task-number: QTBUG-108020 Change-Id: I35aec4f9da9755036141a70f5ce48f6db73d8148 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit 2466273b5b60227427ccca20680542dea9fe581d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Remove commented API for setting set of QVideoSink as output for playerPiotr Srebrny2022-11-071-3/+0
| | | | | | | | | | | | | | | | Reintroducing this API is non-trivial as the current video sink is the main surface that media player and camera view finder render to and depend on. Media player sets up its rendering pipeline to use the rendering hardware associated with the video sink. Thus, when using multiple sinks, one must be selected. Hence, this API does not match well the underlying system. Displaying video in multiple video sinks is easy to achieve with the technique described in the related QTBUG. Fixes: QTBUG-95127 Change-Id: I751f9cac4a02d9d97c5c386f814cc9391ae73c69 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit fe2e90b6e3b61671b94c9e517ce736fba995f3ef) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Allow sinks that do not have associated QRhi to receive video framesPiotr Srebrny2022-11-071-5/+5
| | | | | | | | | | | | | | | | AndroidSurfaceTexture was created only when QVideoSink has an associated QRhi. This enables QVideoSink to display textures created by camera or media player as the textures are created in the OpenGL context associated with QRhi. However, we can allow QVideoSink without QRhi to receive frames as the context sharing can be established later or frames are processed as QImage. Fixes: QTBUG-108027 Change-Id: Iac8925da43aa100fe03c09f57f3d254c27add49c Reviewed-by: Samuel Mira <samuel.mira@qt.io> Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit bd2e80867e4e04fff277cf7340747630d2ea55a4) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update dependencies on '6.4' in qt/qtmultimediaQt Submodule Update Bot2022-11-041-4/+4
| | | | | Change-Id: Id84910ed6d50edbbdbf06aa44aae2e323e9fbea7 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Add missing headers on iOSDoris Verria2022-11-032-0/+4
| | | | | | | | | Include these headers to fix top-level builds and warnings on iOS. Change-Id: I35649f581f2caeed24276ec6751ed390603886a6 Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io> (cherry picked from commit 1b91eb9a9877281cbb985446b81d54086fbc57c9) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QAVFCameraBase: Get max digital zoom factor from the active formatDoris Verria2022-11-031-5/+6
| | | | | | | | | | | | | | | | | | | The camera device's maxAvailableVideoZoomFactor is equal to the device's format videoMaxZoomFactor value on single camera devices, but this is not the case for devices with dual/triple cameras. If we then set the device's zoom factor to a value bigger than the format's videoMaxZoomFactor, this can lead to a crash. So to be on the safe side, get the maximum zoom factor from the format rather than device. Also, directly set the videoZoomFactor of the device if the rate is 0, since setting the factor using rampToVideoZoomFactor:withRate: with a rate of 0, doesn't have any effect. Fixes: QTBUG-108009 Change-Id: Icf7fcdacefd3b1e0084e8ef6cf4de97c6b1b4996 Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io> (cherry picked from commit bc01f4e7c459a591f476dbd23d95ead4c48035ea) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix redundant warning output on macOSArtem Dyomin2022-11-032-11/+19
| | | | | | | | | | | | | | | | | | | Redundant warnings were reproduced with specific installed sowtware, e.g. Soundflower. The software is able to create 64 audio channels and customize them. Basically, all the channels have unknown label, so we should filter the warnings. The logic of channels detection is not changed: only a little bit refactored. See dump of audio channels on client's PC: bugreports.qt.io/secure/attachment/132568/dump_audio_res2.txt Task-number: QTBUG-107678 Change-Id: I85b63d39b71aa09b28d47bf5bf7d40d1e8a1328b Reviewed-by: Doris Verria <doris.verria@qt.io> (cherry picked from commit 68ab44b57d23ac4ecbd663233b9c978b17cd0e98) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix iOS buildDoris Verria2022-11-012-1/+6
| | | | | | | | | Include right headers for macOS and iOS. Change-Id: Ibd1875963a85846ed92267d09385fa17305b2fc3 Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io> (cherry picked from commit 768f6b1064d944824f93cbb5b88cfcf6bbdb905a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update dependencies on '6.4' in qt/qtmultimediaQt Submodule Update Bot2022-10-311-4/+4
| | | | | Change-Id: I0f00593eed7729cc4d7a721c923680c8060657f5 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Windows: do not add audio output to topology when there is no output deviceAndré de la Rocha2022-10-271-12/+7
| | | | | | | | | | | Otherwise videos with audio fail to play when there is no audio output device, instead of just playing the video without audio. Fixes: QTBUG-107205 Change-Id: Ie296023251e3b7c019e63ca09dc68663230aa013 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit d1e3cb9034bf0ebf45b55082217580f4b4a2b790) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix typosPiotr Srebrny2022-10-271-2/+2
| | | | | | | Change-Id: Idcd003a1c2b68c04c4e0b5906c445768cf18f1c8 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit bd233cbcd02eefb35251f7e5c8e8e3c28343df51) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update dependencies on '6.4' in qt/qtmultimediaQt Submodule Update Bot2022-10-271-4/+4
| | | | | Change-Id: I2fc9f042df10afbc7d948dde86740f3e10b21440 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Don't pause playback when in NoMedia, InvalidMedia statePiotr Srebrny2022-10-271-1/+2
| | | | | | | Change-Id: I8a8136df72fa9e28478dfc2917b0dd16f3d8ddc1 Reviewed-by: André de la Rocha <andre.rocha@qt.io> (cherry picked from commit 51bdccb5bbbe4e77a6415730c37392abad25cd40) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Android: fix for changing AudioInput during recordingBartlomiej Moskal2022-10-262-0/+16
| | | | | | | | | | | | Before this commit, changes to the audio input were only applied after restarting the recording. Added support for the audio input switch while recording. Fixes: QTBUG-104530 Change-Id: I933d5d9e218eb9f86cebb2550c5534ced700e58e Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io> (cherry picked from commit 24426e34812e49ec8dda9ee90f5553b7ccf24917) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update dependencies on '6.4' in qt/qtmultimediaQt Submodule Update Bot2022-10-261-6/+6
| | | | | Change-Id: Ifacc5deb1fcf9465b5917588e4379cbbf833c925 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Add move constructor and assignment operatorPiotr Srebrny2022-10-261-0/+14
| | | | | | | | Change-Id: Iec5b96fdd8d167aa1dda49925515752bd68285fc Reviewed-by: Artem Dyomin <artem.dyomin@qt.io> Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit cd1ee9707631f160c1a387a34aefeeb03714db90) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Example: Not working mute for AudioInput in recorderBartlomiej Moskal2022-10-261-1/+1
| | | | | | | | | | | | | The change of switch (next to audio Input source) should affect the example. Mute is now connected to the audioSwitch value. Fixes: QTBUG-107885 Change-Id: I7dd3495916f30dd713ebc7e9c8ae3ccbe734fd49 Reviewed-by: Piotr Srebrny <piotr.srebrny@qt.io> Reviewed-by: Samuel Mira <samuel.mira@qt.io> Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io> (cherry picked from commit f14b25c9a3c9df370c8af3c88726a19a3cc617ca) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Clean up multiplication by AVRational, avoid dividing by 0Piotr Srebrny2022-10-255-26/+47
| | | | | | | | | | | | This patch cleans up multiplication by AVRational as the functions timeStamp() and timeStampUs() gave incorrect value that is far from true when ts is close to 1. Additionally, all multiplication and conversion functions return optional type with nullopt value when rational denominator is 0. Change-Id: I5fbfba29fb4717fd53a67afe825a70cc20c16352 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit 7fa57a2cede08d95c2d868c20052552a04ff6ea5)
* Don't use device.path gst property for device ID, instead generate itPiotr Srebrny2022-10-212-66/+62
| | | | | | | | | | | | The gst_device_get_properties does not work for libcamera; thus, we cannot use the device.path property as the device ID. Instead, we generate ID locally and bind it with GstDevice* in one object. Fixes: QTBUG-104226 Change-Id: I837b74175e48ee15d3fbb3ab26cf21d6a5fea794 Reviewed-by: Lars Knoll <lars@knoll.priv.no> (cherry picked from commit 31430b1d1b2f89cc81a7301013e381cc3fab1a75) Reviewed-by: Lisandro Damián Nicanor Pérez Meyer <perezmeyer@gmail.com>
* Add missing "We mean it" warnings to private headersPaul Olav Tvete2022-10-205-0/+55
| | | | | | | Change-Id: I45175ea0fe88aad8a0403b630a8ca8ab917d813a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit af230ee4c9437f8aba59b79f33c8716592de8a26) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>