From c4b9a0be28bedad16fb16a8ae4ebe89f45fe680b Mon Sep 17 00:00:00 2001 From: Oswald Buddenhagen Date: Wed, 23 Dec 2020 21:54:50 +0100 Subject: gpick: change flag values in complete_spec_heads() from undef to 1 that is consistent with existing use of %visits in fetch_patchsets(), and is generally just much less surprising. Change-Id: I1b09d6842ff8862911ee265b3e833ac311017b97 Reviewed-by: Alexandru Croitor --- bin/git-gpick | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'bin') diff --git a/bin/git-gpick b/bin/git-gpick index 154c42e..b983f62 100755 --- a/bin/git-gpick +++ b/bin/git-gpick @@ -1768,22 +1768,22 @@ sub complete_spec_heads($) my $action = $$spec{action}; if ($action == INSERT) { my ($tip, $base) = ($$spec{tip}, $$spec{base}); - $picks{$tip} = undef; - $picks{$base} = undef if (defined($base)); + $picks{$tip} = 1; + $picks{$base} = 1 if (defined($base)); } else { foreach my $change (@{$$spec{range}}) { my $changeid = $$change{id}; # We do this for deletions as well, to know which Changes # can be dropped safely. - $picks{$changeid} = undef; + $picks{$changeid} = 1; my $pushed = $$change{pushed}; if (defined($pushed)) { - $visits{$pushed} = undef; + $visits{$pushed} = 1; # To be able to set {did_query} once we have the commits. push @queried, $pushed; } my $orig = $$change{orig}; - $visits{$orig} = undef if (defined($orig)); + $visits{$orig} = 1 if (defined($orig)); } } } -- cgit v1.2.1