summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenis Shienkov <denis.shienkov@gmail.com>2013-02-13 11:52:43 +0400
committerThe Qt Project <gerrit-noreply@qt-project.org>2013-02-13 09:28:38 +0100
commitb148feb86548348932da6cc2434ffe11ccc9f0ea (patch)
treecb00e869936996e6a11caf548fc2d69fbcea9d3c
parentb1afe272762e93e2f4a979f1e792b16c3135eb53 (diff)
downloadqtserialport-b148feb86548348932da6cc2434ffe11ccc9f0ea.tar.gz
Windows: Fixed I/O bug in the CommOverlappedEventNotifier
This bug is a critical regression, which makes it impossible to read the data as they become available because CommOverlappedEventNotifier::processCompletionRoutine() returns false if successful completed, i.e. returns a error flag instead of inversion it. Now, processCompletionRoutine() returns true if successful completion. Change-Id: Id5c103017e10dabfaac6017f26afdf76d14b9e65 Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com> Reviewed-by: Laszlo Papp <lpapp@kde.org> Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
-rw-r--r--src/serialport/qserialport_win.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/serialport/qserialport_win.cpp b/src/serialport/qserialport_win.cpp
index 7f86ff3..10a8359 100644
--- a/src/serialport/qserialport_win.cpp
+++ b/src/serialport/qserialport_win.cpp
@@ -158,7 +158,7 @@ public:
if (!error)
dptr->startAsyncRead();
- return error;
+ return !error;
}
private: