From 80dd9dffbc7c7fa2c20954fcd23084f65120b83a Mon Sep 17 00:00:00 2001 From: Joerg Bornemann Date: Tue, 6 Jul 2021 18:24:11 +0200 Subject: CMake: Don't give plugins PUBLIC usage requirements The pro2cmake.py conversion script faithfully reproduced the .pro files for the plugins, which specified the libraries as public. But in CMake, the implications of this are that public usage requirements should then be propagated to consumers. We don't expect any consumers, since a plugin is created as a MODULE library in CMake, so for Windows we don't even have an import library to link with. The only exception to this is for static builds where plugins are created as STATIC libraries instead, but only in certain controlled situations do we then link to plugins. Even then, usage requirements are not expected to propagate to the consumers, so these relationships should always be specified as private. Pick-to: 6.2 Task-number: QTBUG-90819 Change-Id: Ifa2d76d6bff7b29d746455aa070a77cbd06879f0 Reviewed-by: Qt CI Bot Reviewed-by: Alexandru Croitor --- src/plugins/iconengines/svgiconengine/CMakeLists.txt | 2 +- src/plugins/imageformats/svg/CMakeLists.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/plugins/iconengines/svgiconengine/CMakeLists.txt b/src/plugins/iconengines/svgiconengine/CMakeLists.txt index 9371b6e..9c69df5 100644 --- a/src/plugins/iconengines/svgiconengine/CMakeLists.txt +++ b/src/plugins/iconengines/svgiconengine/CMakeLists.txt @@ -10,7 +10,7 @@ qt_internal_add_plugin(QSvgIconPlugin SOURCES main.cpp qsvgiconengine.cpp qsvgiconengine.h - PUBLIC_LIBRARIES + LIBRARIES Qt::Core Qt::CorePrivate Qt::Gui diff --git a/src/plugins/imageformats/svg/CMakeLists.txt b/src/plugins/imageformats/svg/CMakeLists.txt index cec6f77..3c5979f 100644 --- a/src/plugins/imageformats/svg/CMakeLists.txt +++ b/src/plugins/imageformats/svg/CMakeLists.txt @@ -10,7 +10,7 @@ qt_internal_add_plugin(QSvgPlugin SOURCES main.cpp qsvgiohandler.cpp qsvgiohandler.h - PUBLIC_LIBRARIES + LIBRARIES Qt::Core Qt::Gui Qt::Svg -- cgit v1.2.1