diff options
author | Friedemann Kleint <Friedemann.Kleint@theqtcompany.com> | 2015-05-06 09:02:16 +0200 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@theqtcompany.com> | 2015-05-06 08:25:58 +0000 |
commit | a4d77d3cb541cdc368a8ff7ce5bd87599195048e (patch) | |
tree | d0da3dcda737f97d542f5494a25a2262dc800811 | |
parent | 754ba5768623136bdd6ff9c97330193d1a390215 (diff) | |
download | qttools-a4d77d3cb541cdc368a8ff7ce5bd87599195048e.tar.gz |
windeployqt: Additionally check on Qt5WebKit[d].dll for ICU dependency.
Qt 5/Windows is no longer configured with -icu by default, only QtWebKit
still depends in it. Its library needs to be checked for ICU as well.
Task-number: QTBUG-45962
Change-Id: Ib08c2ece446f4f1cc4db2410fc0e554363181a6c
Reviewed-by: Oliver Wolff <oliver.wolff@theqtcompany.com>
-rw-r--r-- | src/windeployqt/main.cpp | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/src/windeployqt/main.cpp b/src/windeployqt/main.cpp index 89bf64440..f1b4b39e2 100644 --- a/src/windeployqt/main.cpp +++ b/src/windeployqt/main.cpp @@ -1063,11 +1063,13 @@ static DeployResult deploy(const Options &options, return result; } - // Some Windows-specific checks in QtCore: ICU + // Some Windows-specific checks: Qt5Core depends on ICU when configured with "-icu". Other than + // that, Qt5WebKit has a hard dependency on ICU. if (options.platform & WindowsBased) { - const QStringList qt5Core = dependentQtLibs.filter(QStringLiteral("Qt5Core"), Qt::CaseInsensitive); - if (!qt5Core.isEmpty()) { - QStringList icuLibs = findDependentLibraries(qt5Core.front(), options.platform, errorMessage).filter(QStringLiteral("ICU"), Qt::CaseInsensitive); + const QStringList qtLibs = dependentQtLibs.filter(QStringLiteral("Qt5Core"), Qt::CaseInsensitive) + + dependentQtLibs.filter(QStringLiteral("Qt5WebKit"), Qt::CaseInsensitive); + foreach (const QString &qtLib, qtLibs) { + QStringList icuLibs = findDependentLibraries(qtLib, options.platform, errorMessage).filter(QStringLiteral("ICU"), Qt::CaseInsensitive); if (!icuLibs.isEmpty()) { // Find out the ICU version to add the data library icudtXX.dll, which does not show // as a dependency. @@ -1088,8 +1090,9 @@ static DeployResult deploy(const Options &options, } dependentQtLibs.push_back(icuPath); } // foreach icuLib + break; } // !icuLibs.isEmpty() - } // Qt5Core + } // Qt5Core/Qt5WebKit } // Windows // Scan Quick2 imports |