summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOswald Buddenhagen <oswald.buddenhagen@digia.com>2013-08-06 15:11:37 +0200
committerThe Qt Project <gerrit-noreply@qt-project.org>2013-08-07 17:04:02 +0200
commitbcaa8575352ad16e1f6020436e1a3f450eefd53e (patch)
tree8e840bacd02d678e5663719f312512749c33d037
parent1ebe6b8fec84591c32f70fdcfafc92fda037e84d (diff)
downloadqttools-bcaa8575352ad16e1f6020436e1a3f450eefd53e.tar.gz
fix strings from #included sources not being collected
Task-number: QTBUG-27974 Change-Id: I30edae2db5449605984a118458b1ccce7ad67eb1 Reviewed-by: hjk <hjk121@nokiamail.com> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
-rw-r--r--src/linguist/lupdate/cpp.cpp1
-rw-r--r--tests/auto/linguist/lupdate/testdata/good/parsecpp/included.cpp42
-rw-r--r--tests/auto/linguist/lupdate/testdata/good/parsecpp/main.cpp5
-rw-r--r--tests/auto/linguist/lupdate/testdata/good/parsecpp/project.ts.result5
4 files changed, 53 insertions, 0 deletions
diff --git a/src/linguist/lupdate/cpp.cpp b/src/linguist/lupdate/cpp.cpp
index 2ed6be54d..65176ec6d 100644
--- a/src/linguist/lupdate/cpp.cpp
+++ b/src/linguist/lupdate/cpp.cpp
@@ -1437,6 +1437,7 @@ void CppParser::processInclude(const QString &file, ConversionData &cd, const QS
parser.functionContextUnresolved = functionContextUnresolved;
parser.pendingContext = pendingContext;
parser.setInput(ts, cleanFile);
+ parser.setTranslator(tor);
QStringList stack = includeStack;
stack << cleanFile;
parser.parseInternal(cd, stack, inclusions);
diff --git a/tests/auto/linguist/lupdate/testdata/good/parsecpp/included.cpp b/tests/auto/linguist/lupdate/testdata/good/parsecpp/included.cpp
new file mode 100644
index 000000000..a6b1a1826
--- /dev/null
+++ b/tests/auto/linguist/lupdate/testdata/good/parsecpp/included.cpp
@@ -0,0 +1,42 @@
+/****************************************************************************
+**
+** Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).
+** Contact: http://www.qt-project.org/legal
+**
+** This file is part of the test suite of the Qt Toolkit.
+**
+** $QT_BEGIN_LICENSE:LGPL$
+** Commercial License Usage
+** Licensees holding valid commercial Qt licenses may use this file in
+** accordance with the commercial license agreement provided with the
+** Software or, alternatively, in accordance with the terms contained in
+** a written agreement between you and Digia. For licensing terms and
+** conditions see http://qt.digia.com/licensing. For further information
+** use the contact form at http://qt.digia.com/contact-us.
+**
+** GNU Lesser General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU Lesser
+** General Public License version 2.1 as published by the Free Software
+** Foundation and appearing in the file LICENSE.LGPL included in the
+** packaging of this file. Please review the following information to
+** ensure the GNU Lesser General Public License version 2.1 requirements
+** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
+**
+** In addition, as a special exception, Digia gives you certain additional
+** rights. These rights are described in the Digia Qt LGPL Exception
+** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
+**
+** GNU General Public License Usage
+** Alternatively, this file may be used under the terms of the GNU
+** General Public License version 3.0 as published by the Free Software
+** Foundation and appearing in the file LICENSE.GPL included in the
+** packaging of this file. Please review the following information to
+** ensure the GNU General Public License version 3.0 requirements will be
+** met: http://www.gnu.org/copyleft/gpl.html.
+**
+**
+** $QT_END_LICENSE$
+**
+****************************************************************************/
+
+QObject::tr("message from #included .cpp file");
diff --git a/tests/auto/linguist/lupdate/testdata/good/parsecpp/main.cpp b/tests/auto/linguist/lupdate/testdata/good/parsecpp/main.cpp
index bbd29e3b5..54781ba9f 100644
--- a/tests/auto/linguist/lupdate/testdata/good/parsecpp/main.cpp
+++ b/tests/auto/linguist/lupdate/testdata/good/parsecpp/main.cpp
@@ -394,3 +394,8 @@ Class42::Class42() :
Class42::hello(int something /*= 17 */, QString str = Class42::tr("eyo"))
{
}
+
+
+
+// QTBUG-27974: strings from included sources are not collected
+#include "included.cpp"
diff --git a/tests/auto/linguist/lupdate/testdata/good/parsecpp/project.ts.result b/tests/auto/linguist/lupdate/testdata/good/parsecpp/project.ts.result
index 83eb95eba..db908d987 100644
--- a/tests/auto/linguist/lupdate/testdata/good/parsecpp/project.ts.result
+++ b/tests/auto/linguist/lupdate/testdata/good/parsecpp/project.ts.result
@@ -251,6 +251,11 @@ backslashed \ stuff.</source>
<source>just QObject</source>
<translation type="unfinished"></translation>
</message>
+ <message>
+ <location filename="included.cpp" line="42"/>
+ <source>message from #included .cpp file</source>
+ <translation type="unfinished"></translation>
+ </message>
</context>
<context>
<name>QTranslator</name>