QDoc: Code cleanup

* Use multiple arguments for QStrings instead of calling
  .arg() multiple times.
* Define trivial constructor/destructor '= default' instead of adding
  empty implementations.
* Remove unreachable code.
* Prefer ranged-based for loops.
* Initialize with auto from static_cast<>() and new.
* Simplify expressions.
* Prefer "QList::empty()" over "QList::size() > 0".
* Remove unused method.
* Return qsizetype instead of int to avoid narrowing conversion.
* Remove unused include.
* Remove unreachable return statement.
* Prefer raw string literals over escaped regexes.
* Initialize struct members.
* Make variables used as const refs const refs.
* Use std::move instead of passing const ref in ctor.
* Drop redundant 'virtual' from methods marked 'override'.
* Make local copies that arent ever modified const refs to avoid copying.
* Turn for-loop into std::any_of.
* Made single-argument constructor explicit.
* Don't shadow variable names from outer scope if not necessary.
* Remove const at top level that does not improve const correctness.
* Update copyright notice for affected classes.

Task-number: QTBUG-71176
Change-Id: Ia41e5b947b72f594b60d189b6b0ff68587c3afb9
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>

1 files changed, 3 insertions, 4 deletions

diff --git a/src/qdoc/helpprojectwriter.h b/src/qdoc/helpprojectwriter.h
index 1f465e8e2..691c21608 100644
--- a/src/qdoc/helpprojectwriter.h
+++ b/src/qdoc/helpprojectwriter.h
@@ -1,6 +1,6 @@
 /****************************************************************************
 **
-** Copyright (C) 2019 The Qt Company Ltd.
+** Copyright (C) 2021 The Qt Company Ltd.
 ** Contact: https://www.qt.io/licensing/
 **
 ** This file is part of the tools applications of the Qt Toolkit.
@@ -100,7 +100,6 @@ public:
     HelpProjectWriter(const QString &defaultFileName, Generator *g);
     void reset(const QString &defaultFileName, Generator *g);
     void addExtraFile(const QString &file);
-    void addExtraFiles(const QSet<QString> &files);
     void generate();
 
 private:
@@ -114,8 +113,8 @@ private:
     void addMembers(HelpProject &project, QXmlStreamWriter &writer, const Node *node);
     void writeSection(QXmlStreamWriter &writer, const QString &path, const QString &value);
 
-    QDocDatabase *qdb_;
-    Generator *gen_;
+    QDocDatabase *qdb_ {};
+    Generator *gen_ {};
 
     QString outputDir;
     QList<HelpProject> projects;