| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| |
| |
| |
| | |
The Qt version was added in 5.14 "for use as eventual replacement for
QString::SplitBehavior." Move another step closer to that goal.
Change-Id: I7137cf8339bfe9fdcf4cb7cc695cb146aef410fb
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With the internal API version 8, the SourceLocation will move from
QQmlJS::AST to the QQmlJS namespace, and it will get its
loc.startLine/loc.startColumn members back.
Change-Id: I70ba5a7f7b6eca60298a7b4982bf2cf099110089
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The q->tr()-calls ended up in the context
QHelpFilterSettingsWidgetPrivate. Use the static invocation to fix
this.
Change-Id: Iec232532e34cae19fac2f06462207170ba40bdca
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The command was documented as taking no arguments, and any arguments
were ignored. The documentation still has many instances of
\obsolete Use somethingElse() instead.
Where the description was lost. Force a linebreak after the command,
allowing any arguments to be processed as a normal text paragraph.
[ChangeLog][qdoc] Generate output for arguments passed to the \obsolete
command.
Fixes: QTBUG-82558
Change-Id: If3e39382367a0c1f4cc63a2c322e986e053ecd6b
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since skipSpacesOnLine() can end up making pos == len then we need to
check pos is less than length before querying input_ with that position.
This fixes the warning "Using QCharRef with an index pointing outside
the valid range of a QString. The corresponding behavior is deprecated,
and will be changed in a future version of Qt."
Fixes: QTBUG-80346
Change-Id: Ica1c57f616c3efaefd597ebb84e52b17325d22fa
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|\ \
| |/
| |
| | |
Change-Id: I867bda11a1298693cec285183435f4ae399208da
|
| |
| |
| |
| |
| |
| |
| | |
In most cases, the letter "v" is always lower-cased.
Change-Id: I3748357f548f62b6ea7f6d1f3ee8d404fec34f8b
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
By default, qdoc supports \include files from the sourcedirs only.
It should also consider files to \include from the exampledirs, like
it does for the \snippet and \quotefromfile commands.
In addition, added a test to check if the \include works
for files exampledirs.
Change-Id: I9ce0b1905bfd0413022a4b4cab42588e4540e70e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As Location is not a CoW class, the use of Location::null over
Location() seems unfounded. Remove the static null object and replace
its use.
Change-Id: I27dd4dfabffbfedb4f310dac43614e1ebb03c522
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The <a name="..."> elements used for anchors are obsolete, but it
turns out the QTextBrowser backend for offline documentation still
relies on them. Re-introduce them into the output.
This commit partially reverts 5aa19d92.
Fixes: QTBUG-82034
Change-Id: Ia4af9c2ed809b12c5f79d27db4dd3eb5e9523d13
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| | |
Fixes: QTBUG-48218
Change-Id: Iedbb20225d41cfd3213b8b7a1737da41b4e64561
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I39d10454442178e6f1292d136eea8ee990ad162f
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QDoc generated different output for two consecutive runs because
we were sorting nodes based on the addresses of node pointers.
Use the existing comparison function for sorting nodes. This makes
QDoc's output deterministic.
Fixes: QTBUG-81712
Change-Id: I5e80c82d7582d76c4a3ac1e656f8480159d35240
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Levon Sargsyan <levon.sargsyan@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Make Node::isObsolete() virtual and override it for FunctionNode.
This is needed to treat access functions of obsolete properties
also as obsolete.
Remove FunctionNode::hasActiveAssociatedProperty() as it was a
workaround for isObsolete() not being complete for function nodes.
Fixes: QTBUG-79386
Change-Id: If7597ca19f35b4582979bed36f628874c5beac07
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The 'examplesinstallpath' configuration variable assumes that all
examples - once installed - are located under a common root path.
Add a parameter 'installpath', recognized by the \meta command,
which can be used for setting the install path for specified
examples.
Improve the test for examples-manifest.xml to cover the \meta
command usage.
Task-number: QTBUG-81360
Change-Id: Ibb525a48958005fb3a589ef2d9d212091829231f
Reviewed-by: Levon Sargsyan <levon.sargsyan@qt.io>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Cherry-pick of efa183309e69f317189ef06fb1f13b60da9d7c63. Looks like it
was never cherry-picked as intended.
Change-Id: Iad959315ad374ef288f5fffd15d684efbcdc6197
Reviewed-by: Ville Voutilainen <ville.voutilainen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
The comment was present on the existing strings. Amends
7fd5d435b76460e42cd25004056a39e05f376baa.
Change-Id: Ic5a03c3b63a974956845ad2a3d1fb6c7d4df98a2
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QDoc warns about a missing \inmodule command and tells us that it has
selected a default (project) name for the module, but this had no
effect because we never added the node to the module.
Automatically adding the node to the module won't eliminate the
warnings, but ensures that a \module page whose name matches the
default one is populated with the classes/namespaces as expected.
Change-Id: Ib6a949cc2763c254d379ff99b08c60812f45e607
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This undocumented command was storing a list of keywords in a node.
Those keywords were never accessed.
Task-number: QTBUG-82310
Change-Id: I144454667c78329a8a03ca81b9b90b047971d301
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Very useful to discover what compressed texture formats are supported
on a given system with a given backend.
Also change the OpenGL ES label to be more generic.
Change-Id: Iaf44d9ee7e78afaf8d067fc85747f4bae19f00c3
Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Initializing Config as nullptr in DocBook class,
avoiding potential undefined behavior.
Coverity-id: 266393
Change-Id: I0330d86b750f2a972c21875bc776407bc94c81df
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Writing \fn commands for member functions of classes declared under
a namespace was error-prone as QDoc required the fully qualified
paths for the function signature, even though the documentation
comment was located under the correct namespace scope.
Store the scope by backtracking the Clang AST until we reach the
level of the translation unit, and store each encountered namespace
declaration into a list. When generating the temporary source file
for an \fn command, we can then recreate the correct namespace
hierarchy.
This does not break the existing \fn command usage as it's perfectly
valid, even if unnecessary, to provide fully qualified paths in the
function signature.
[ChangeLog][qdoc] QDoc is now aware of the namespace scope of an \fn
command without requiring fully qualified paths.
Fixes: QTBUG-82190
Change-Id: Ia446c19d130b2ef48b16b67e4dfcbdaab1f9d4f5
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I98eaf748fdfb34f32d187718459327b8eef9c54b
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
DocBookGenerator::generateExampleFilePage() constructs a new writer
instance while another one is still in use. Store the old one, and
restore it once the example page has been generated.
Fixes: QTBUG-82251
Change-Id: Ic41c8fed82c27723198415a32bca0225b36922b3
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I1437ecfcca7c28741e350f8390461a07f2a01612
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
This change is a prerequisite for disentangling Config from Generator.
Change-Id: Ib073bd8fcaf743530ed68271373b885fa4bef46b
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Run clang-format across QDoc, this is the result.
Change-Id: Iaabad0a07a0495990013cbf5995c65db531a7d0d
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Make constructor explicit
- Add some const for clarity
- Fix style issues, include convention
Change-Id: Ic90c446dde66ab21a0ba621c6dfa939adb822c4e
Reviewed-by: Karsten Heimrich <karsten.heimrich@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
This amends 9e694337058
Change-Id: Ice498c525130a895eb1079391d2a5facf923ffc2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Fix warnings introduced qtbase/11dc7b35c8c3957bd19087a5e3ae7cfc4f1a3343.
Task-number: QTBUG-81845
Change-Id: I49169c34ec9aaff3625bcb9dfaef1d29b7beae07
Reviewed-by: Vitaly Fanaskov <vitaly.fanaskov@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Stop passing a writer reference around, make it a member.
- Make static functions non-static members.
- Initialize one variable per line and remove a commented out line.
Task-number: QTBUG-37355
Change-Id: I32a7494dbc7425d3bd8357821c51c88f29f1c6c1
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Change-Id: If99edd8bc31733208fb2d82dc9f19b761693be1c
Reviewed-by: Levon Sargsyan <levon.sargsyan@qt.io>
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Use correct tag member name.
* Use correct tag names when writing tag-files.
* Also prefer ranged-for in a loop.
Fixes: QTBUG-61790
Change-Id: I486fcd125f473f72c497ccbd1e9f7baa371bcebc
Done-With: Maxim Paperno <max@wdg.us>
Reviewed-by: Maxim Paperno <max@wdg.us>
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
As most of the code related to generating DITA has been pulled out,
remove also the references to it in the documentation.
Change-Id: I420242f236faf3b89baea1547421a1f50d91762f
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In Generator::generateReimplementsClause(), QDoc tries to output
reimplementation information for function nodes, and intends to
print out a warning if there is no documented virtual function
in the base class to override.
This warning was triggered too often - especially, when the
base implementation was an \internal class, and the documented
reimplementation did not even use the \reimp command.
This commit fixes the warning to be omitted for \internal
base member functions.
Change-Id: Ic39327520b28e5034c489a4037297210fa8b10d9
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Replace by QMap::insert(), fixing:
shared\qlayout_widget.cpp:1918:79: warning: 'QMap<K, V>& QMap<K, V>::unite(const QMap<K, V>&) [with Key = int; T = bool]' is deprecated: Use QMultiMap for maps storing multiple values with the same key. [-Wdeprecated-declarations]
shared\qlayout_widget.cpp:1922:82: warning: 'QMap<K, V>& QMap<K, V>::unite(const QMap<K, V>&) [with Key = int; T = bool]' is deprecated: Use QMultiMap for maps storing multiple values with the same key. [-Wdeprecated-declarations]
Change-Id: I57c48aa52399b2a372c683aab8117bb8031002af
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The DocBook generator overloads virtual methods inherited from
Generator. As there is no overload resolution across scopes, add
`using` declarations to silence compiler warnings (from clang-8)
about hidden virtual function overloads ([-Woverloaded-virtual]).
This patch also removes one unused private member
([-Wunused-private-field]).
Change-Id: I9f1677b637138f607db626bbcde032ec71b20fe4
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Often, a documented class inherits from a base that lives in
another documentation module. QDoc recorded only the class
name of such bases, omitting any qualified path. Fix this issue
in the Clang-parser.
Add an autotest for verifying documentation with cross-module
inheritance and links. This requires adding a mechanism for
copying the generated .index file(s) into a location where
QDoc searches index files in.
Fixes: QTBUG-81793
Change-Id: I4019a1ca3a0e4c69bccc1a92740fd51907bfb24d
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
.ts, XLIFF ... contain the target language as part of the content.
By embedding this information in the .qm file we can extend
QTranslator so that it exposes the language a translation is
actually for.
Change-Id: I9a98cdf7366ab05477a0b4c1e5a2538181e06977
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fix warning:
shared\iconselector.cpp: In member function 'void qdesigner_internal::IconThemeEditor::updatePreview(const QString&)':
shared\iconselector.cpp:594:64: warning: 'const QPixmap* QLabel::pixmap() const' is deprecated: Use the other overload which returns QPixmap by-value [-Wdeprecated-declarations]
const QPixmap *currentPixmap = d->m_themeLabel->pixmap();
Change-Id: Ib15a354133f65b5a55edfe5e11a046aa675ac0a2
Reviewed-by: Sze Howe Koh <szehowe.koh@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fix deprecation warning:
centralwidget.cpp:608:74: warning: 'void QTextBrowser::highlighted(const QString&)' is deprecated: Use QTextBrowser::highlighted(QUrl) instead [-Wdeprecated-declarations]
connect(page, QOverload<const QString &>::of(&HelpViewer::highlighted),
Change-Id: I34e0c02072736433464a70d0454633d414e89885
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
|
|\ \ |
|
| |\ \
| | |/
| | |
| | | |
Change-Id: I30a35e0998cd2538406ae5e11e2991f855f4ecb5
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Nodes sharing a comment will be listed together as a group, so
sort them alphabetically.
Fixes: QTBUG-81265
Change-Id: Ia8dcba92d74116bf6757bfc9aaded1c65d7271fd
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Property groups from base types were not listed on 'All Members'
pages of a QML type. This was because we skipped all shared
comment nodes for base types; property group is a special type
of SCN.
Remove duplication in the code that distributes the nodes; this
ensures that there is no difference in output between members of
a type and members inherited from its base types. Use logging
category to display debug warnings instead of qDebug().
Add a test to cover this.
Fixes: QTBUG-81262
Change-Id: I46c3e6afa87c510a7929088acbd1fb354f6733af
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add "git" as allowed optional version string suffix.
Fixes: QTBUG-81534
Change-Id: Ia83d924f4e16045b464e94954b544d3d2c111523
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add the option to place a file with the suffix .entitlements into the
Contents/Resources subdirectory of an application bundle. The
entitlements listed in the file will be used for signing.
Bundles that are depoloyed as part of another bundle (e.g. Helpers)
can specify a separate set of entitlements from the main bundle by
including an entitlements file of their own.
Only the first entitlement file per bundle will be used for signing as
the codesign tool will only use one entitlements file even when multple
are specified.
Task-number: QTBUG-77442
Change-Id: Iea356c1a70713f3a4b07281245a17fd7c87f6b11
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-74137
Task-number: QTBUG-80477
Change-Id: Ib33f27e476bad1cdffda1539c8befaea9070a7e6
Reviewed-by: Leander Beernaert <leander.beernaert@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Class nodes marked with \dontdocument are not supposed to be seen
in the generated documentation. They already did not generate an
output page, but they still appeared as base classes in 'Inherits'
information as well as class listings, resulting in broken links.
Remove these nodes from all relevant lists. Handle Node::DontDocument
status in the .index files, and add a test to cover \dontdocument
usage.
Fixes: QTBUG-81468
Change-Id: I933817ff0ebf372cfa493a5ea824b682e0b1b160
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A special case of QML type documentation is a one where a type does
not require an import statement to be usable, and is not a basic type.
If the \inqmlmodule command was omitted, QDoc warned about it and
generated an incomplete import statement in the type reference.
We still want to see those warnings as they often are valid, but
allow the above usecase by marking a QML module \internal:
/*!
\qmlmodule internal 1.0
\internal
*/
/*!
\qmltype SomeType
\inqmlmodule internal
*/
Such a type will generate otherwise normal reference page, but without
an import statement. Also, the (internal) module name will not appear
in the generated file names (qml-sometype.html).
Fixes: QTBUG-81613
Change-Id: I50bb08f48fc4e7dbc7602ab20de39e039213810b
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|