From 2ea853ba28e359fba7f98ba1286bc5c89a48105a Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Tue, 31 Jul 2018 12:48:24 +0200 Subject: Qt Designer: Fix clang-tidy warnings about Qt usage - Use multi-arg form of QString::arg() - Fix static method calls - Prefer QFileInfo::exists() - Use isEmpty() for containers instead of checking size() - Use QOverload Change-Id: I31e92f77d0fa377932c1369afe2503abc8ecceac Reviewed-by: Jarek Kobus --- src/designer/src/lib/shared/iconselector.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/designer/src/lib/shared/iconselector.cpp') diff --git a/src/designer/src/lib/shared/iconselector.cpp b/src/designer/src/lib/shared/iconselector.cpp index 303a2e2a6..f84b30173 100644 --- a/src/designer/src/lib/shared/iconselector.cpp +++ b/src/designer/src/lib/shared/iconselector.cpp @@ -321,7 +321,8 @@ bool IconSelector::checkPixmap(const QString &fileName, CheckMode cm, QString *e QImageReader reader(fileName); if (!reader.canRead()) { if (errorMessage) - *errorMessage = tr("The file '%1' does not appear to be a valid pixmap file: %2").arg(fileName).arg(reader.errorString()); + *errorMessage = tr("The file '%1' does not appear to be a valid pixmap file: %2") + .arg(fileName, reader.errorString()); return false; } if (cm == CheckFast) @@ -330,7 +331,8 @@ bool IconSelector::checkPixmap(const QString &fileName, CheckMode cm, QString *e const QImage image = reader.read(); if (image.isNull()) { if (errorMessage) - *errorMessage = tr("The file '%1' could not be read: %2").arg(fileName).arg(reader.errorString()); + *errorMessage = tr("The file '%1' could not be read: %2") + .arg(fileName, reader.errorString()); return false; } return true; -- cgit v1.2.1