diff options
| author | David Edmundson <davidedmundson@kde.org> | 2020-04-08 18:19:00 +0100 |
|---|---|---|
| committer | David Edmundson <davidedmundson@kde.org> | 2020-04-23 09:49:31 +0100 |
| commit | 4bd13402f0293e85b8dfdf92254e250ac28094c7 (patch) | |
| tree | afe0ec21e045a8089971f2c7b0c6f3b3f36f6d7c /src/hardwareintegration/client/wayland-egl/qwaylandeglwindow.h | |
| parent | b69e62f7b5d11990c2b75045ec67d7179e823e17 (diff) | |
| download | qtwayland-4bd13402f0293e85b8dfdf92254e250ac28094c7.tar.gz | |
Client: Reset wl_egl_window before wl_surface
Semantically we want things in this order as wl_egl_window_create takes
a reference to the wl_surface. Teardown typically is the opposite of
construction.
This brings us in line with GTK which also tears down in this order.
This fixes a repeatable crash when using Nvidia's EGLStreams and closing
a window.
Change-Id: I356dfbba9a7315717c8ecdc7023ca7b047622697
Reviewed-by: Frederik Gladhorn <gladhorn@kde.org>
Reviewed-by: Johan Helsing <johanhelsing@gmail.com>
Diffstat (limited to 'src/hardwareintegration/client/wayland-egl/qwaylandeglwindow.h')
| -rw-r--r-- | src/hardwareintegration/client/wayland-egl/qwaylandeglwindow.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/hardwareintegration/client/wayland-egl/qwaylandeglwindow.h b/src/hardwareintegration/client/wayland-egl/qwaylandeglwindow.h index 878532af..5b1f4d56 100644 --- a/src/hardwareintegration/client/wayland-egl/qwaylandeglwindow.h +++ b/src/hardwareintegration/client/wayland-egl/qwaylandeglwindow.h @@ -75,7 +75,6 @@ public: void bindContentFBO(); void invalidateSurface() override; - void setVisible(bool visible) override; private: QWaylandEglClientBufferIntegration *m_clientBufferIntegration = nullptr; |