summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael BrĂ¼ning <michael.bruning@qt.io>2020-09-29 15:13:40 +0200
committerMichael BrĂ¼ning <michael.bruning@qt.io>2020-10-05 12:02:13 +0000
commitb59af853f7b36829bda7c4947028e058017d4efd (patch)
treec0335a99c871a8ede53d23713690d24cf5ff5f1e
parentca61def88f8207d681846f576bc0d28a7b73afbc (diff)
downloadqtwebengine-chromium-b59af853f7b36829bda7c4947028e058017d4efd.tar.gz
[Backport] CVE-2020-6559: Use after free in presentation API
[Presentation API] Fix use-after-free. This fixes a potential UAF in PresentationConnectionCallbacks::OnSuccess. TBR=mlamouri@chromium.org (cherry picked from commit 42a17e378ad7efbf57d47f3a7612d7c7cf95a907) Bug: 1116706 Change-Id: I25fc55edf968f41bfedecbeb2054a5eae56d0de7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
-rw-r--r--chromium/third_party/blink/renderer/modules/presentation/presentation_connection_callbacks.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/chromium/third_party/blink/renderer/modules/presentation/presentation_connection_callbacks.cc b/chromium/third_party/blink/renderer/modules/presentation/presentation_connection_callbacks.cc
index fa2ab28362e..79c513242dd 100644
--- a/chromium/third_party/blink/renderer/modules/presentation/presentation_connection_callbacks.cc
+++ b/chromium/third_party/blink/renderer/modules/presentation/presentation_connection_callbacks.cc
@@ -57,8 +57,8 @@ void PresentationConnectionCallbacks::OnSuccess(
resolver_.Get(), presentation_info, request_);
}
- resolver_->Resolve(connection_);
connection_->Init();
+ resolver_->Resolve(connection_);
}
void PresentationConnectionCallbacks::OnError(