diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2019-02-13 15:05:36 +0100 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2019-02-14 10:33:47 +0000 |
| commit | e684a3455bcc29a6e3e66a004e352dea4e1141e7 (patch) | |
| tree | d55b4003bde34d7d05f558f02cfd82b2a66a7aac /chromium/styleguide/java/java.md | |
| parent | 2b94bfe47ccb6c08047959d1c26e392919550e86 (diff) | |
| download | qtwebengine-chromium-e684a3455bcc29a6e3e66a004e352dea4e1141e7.tar.gz | |
BASELINE: Update Chromium to 72.0.3626.110 and Ninja to 1.9.0
Change-Id: Ic57220b00ecc929a893c91f5cc552f5d3e99e922
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Diffstat (limited to 'chromium/styleguide/java/java.md')
| -rw-r--r-- | chromium/styleguide/java/java.md | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/chromium/styleguide/java/java.md b/chromium/styleguide/java/java.md index 530b779f618..46815e917e9 100644 --- a/chromium/styleguide/java/java.md +++ b/chromium/styleguide/java/java.md @@ -114,6 +114,18 @@ if (org.chromium.base.BuildConfig.DCHECK_IS_ON) { } ``` +### Finalizers +In line with [Google's Java style guide](https://google.github.io/styleguide/javaguide.html#s6.4-finalizers), +never override `Object.finalize()`. + +Custom finalizers: +* are called on a background thread, and at an unpredicatble point in time, +* swallow all exceptions (asserts won't work), +* causes additional garbage collector jank. + +Classes that need destructor logic should provide an explicit `destroy()` +method. + ### Other Android Support Library Annotations * Use them! They are [documented here](https://developer.android.com/studio/write/annotations). * They generally improve readability. |