summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Add isysroot parameter for macOS to build gn with the right toolchainv5.13.0-beta171-basedMichael Brüning2019-03-011-1/+4
| | | | | | | | | | | | | | | Uses the isysroot passed in, which will be set to $$QMAKE_MAC_SDK_PATH by the WebEngine build scripts. Leaving this out when specifying a tool chain leads to problems on macOS 10.14 when the command line tools are also installed, as some symlinks point to the wrong clang executable. We also add the isysroot for the rest of Qt and Chromium detects it as well, so this adds to consistency as well. Change-Id: I48ec9e37ee27c7dfa717c00cceefd3acc323cc48 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Soften check for single thread only if layer1 or layer2 sandboxMichal Klocek2019-02-273-4/+8
| | | | | | | | | | | | | | Currently qemu emulation for arm spawns some threads before entering level 1 of sandbox. Chromium code is written to make check even before trying to check support for layer1 sandbox (even with --no-sandbox flag) Make minimal code change to simply avoid the check if level1 or level2 sandbox is not supported or unwanted. Task-number: QTBUG-63346 Change-Id: Ia017f97281b7e41fbf2294e58a6ea77c838f6bd6 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix not working ar on windowsMichal Klocek2019-02-211-1/+7
| | | | | | | Make ar optional. Change-Id: Ib457d45ff2855edea4babf39c30fc905a46684cc Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix builds with no xrandrMichal Klocek2019-02-201-0/+2
| | | | | | | Since 3f7ea91e23 we should not depend on xrandr. Change-Id: I027500320e22a34e71ebd3105013d9e298ea2994 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Disable download and print buttons in PDF viewerMichael Brüning2019-02-181-1/+2
| | | | | | | | They have no function at the moment, but may be enabled as it becomes possible. Change-Id: Ic173ad41f4557b83f94b8998eca488d15c405cef Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix extensions build for Windows on 71-basedMichael Brüning2019-02-152-2/+2
| | | | | | | | | Missing return value and narrowing conversion were reported as as errors by MSVC, which seems to be a bit stricter for some things than the other compilers. Change-Id: I58f07d79a823ffabf70f2c1da2de5469506ed2a3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Bypass CHECK for uninitialized resources when destroying plugin hostMichael Brüning2019-02-152-3/+11
| | | | | | | | | | | | We have previously disabled the release asserts for plugin resources that could not be initialized. However, there was still a CHECK when destroying theses unintitalized resource, as there is no way to report the initialization failure back. This patch adds tracking of the failed initializations and bypasses the CHECK for those that previously failed. Change-Id: I95893670e172af70cfd716574f769dd7e49d20ef Task-number: QTBUG-64832 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix build with sanitizer and iceccMichal Klocek2019-02-151-1/+2
| | | | | | | | Do not use blacklist.txt file for asan, icecc does not handle it properly, moreover the file is empty anyway. Change-Id: I8d53ef27ef688cda464ca1278d7c9673ec74b58a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add command line parameters for cc,cxx,ld,ar in gnMichal Klocek2019-02-151-15/+31
| | | | | Change-Id: I122070cdf1dc9a54f7dfdf39c86bd8aadbd8a14c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fixup build with older system ICUAllan Sandfeld Jensen2019-02-041-2/+4
| | | | | Change-Id: Iedcb19b03b41400acabc1ae0ae6f6f9111f34d46 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Merge remote-tracking branch 'origin/upstream-master' into 71-basedAllan Sandfeld Jensen2019-02-04814-352/+174541
|\ | | | | | | Change-Id: Id64d87edf3764b7b2a539f34018a458c8fcce302
| * BASELINE: Update Chromium to 71.0.3578.140Allan Sandfeld Jensen2019-01-29814-352/+174541
| | | | | | | | | | Change-Id: Ia85516cc06e245e449ca8a6652242b8a1bcace74 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Use chromium setting for persistent web notification idsv5.13.0-alpha1Kirill Burtsev2019-02-012-0/+4
| | | | | | | | | | Change-Id: I38e65848da7c92adc6be87175ca9da3fe496a3dd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Fixup non-extensions build on 71-basedMichael Brüning2019-02-019-18/+32
| | | | | | | | | | Change-Id: I7ce92ba0edc4b196ca05224729d3eb31748a7780 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Fixup extensions / pdf code for 71-basedMichael Brüning2019-01-319-25/+27
| | | | | | | | | | | | | | | | | | | | | | Includes: * Flagging out unsupprted API from PDF viewer JavaScript files * Correctly excluding apps_shim build files in no-extension builds * Flagging out the extensions update method * Miscellaneous adaptations Change-Id: Ie4d95c1ca991bce8f064a99fc78d1e1ed9626d2d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Make text selection handles available on macOS tooPeter Varga2019-01-301-1/+1
| | | | | | | | | | | | Task-number: QTBUG-59999 Change-Id: I67b67aa88e1ef985441d8b3bd86d02ee265b38cf Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | Minor. Drop dependency for ffmpeg for test_supportMichal Klocek2019-01-291-1/+1
| | | | | | | | | | | | | | | | | | This just cleans dependencies for ffmpeg. I should be now enough to unset media_use_ffmpeg, use_webaudio_ffmpeg to skip ffmpeg. Change-Id: I3b5b5a88b368f927413c605ec7ee7ff6687352e8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | FIXUP: Windows post-merge fixupsPeter Varga2019-01-251-0/+1
| | | | | | | | | | | | | | Add missing return. Change-Id: Iff84856946842e68a7dd1783a0b4eae976529f81 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Add check for Xcode clang to fix building on macOS 10.12Alexandru Croitor2019-01-241-1/+2
| | | | | | | | | | | | | | | | Target attribute avx2 doesn't seem to work on older Apple clangs. Change-Id: If56fbb2e6ef72786527f2507ae70d01ba5182b35 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Revert: Move RTC_CHECK_OP error message construction out of header file.Allan Sandfeld Jensen2019-01-243-117/+147
| | | | | | | | | | | | | | | | | | Doesn't build with older MSVC 2017 versions. Reverts https://webrtc-review.googlesource.com/86544 Change-Id: Ieb80a6717929d153e39a2f04cb8a85631a03bc7a Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Fix building bundled zlib on non-clangAllan Sandfeld Jensen2019-01-241-1/+1
| | | | | | | | | | | | | | The check for adding the logic and for adding the sources didn't match. Change-Id: I843a8e24fbf666c8ce1340d1ae0d21fc5b66101a Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | FIXUP: Windows post-merge fixupsAllan Sandfeld Jensen2019-01-233-4/+9
| | | | | | | | | | | | | | Fix build for x86 as well. Change-Id: I3338ad68634766ae3d8222a18346007c4bcbfae8 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | Pass Qt Prefix path to the macOS V2 Seatbelt SandboxAlexandru Croitor2019-01-234-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | The render process requires access to the Qt resources directory (for ICU data files for example). Pass the Qt prefix path to the sandbox rules, to allow file read access. Change-Id: I2364ef4711d225aae2d14da78e33c609f4f8b5bd Fixes: QTBUG-73089 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | [Backport][WebRTC] Remove event wait logic from DesktopConfigurationMonitorPeter Varga2019-01-235-63/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This class exposes Wait()-Set() logic to synchronize events. - There is a bug in checking EventWrapper::Wait() as it returns [1,2]. Negating these values cause us to always pass timeout checks. - There is a general problem in this class with waiter. There are 2 scenarios: 1) Lock()-Unlock()-DisplaysReconfigured() In this scenario, Wait() in DisplaysReconfigured() immediately passes as event is already signaled. Next Lock() call won't continue until Set() is called in DisplaysReconfigured(). This blocks capture thread from accessing display until reconfiguration completes. 2) Lock()-DisplaysReconfigured()-Unlock() In this scenario, Wait() in DisplaysReconfigured() passes when Unlock() called. Capture thread accesses display while reconfiguration happens. Note that we are only delaying the OS delegate thread here. As an experiment, adding Sleep() in DisplaysReconfigured() results in no change, because it looks like OS uses this thread for only delegates but not for the actual display switch. Overall, (1) doesnt seem necessary as (2) already accesses display while reconfiguration happens. (2) doesn't seem necessary as blocking system delegate thread doesn't help. Therefore, I changed the class to only protect from race condition on |desktop_configuration_|. Bug: chromium:796889 Change-Id: I5a70c4efff999204eab8b1cfd66cbfe953b26467 Reviewed-on: https://webrtc-review.googlesource.com/c/108560 Commit-Queue: Emircan Uysaler <emircan@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25437} Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | FIXUP: Bring enable_webrtc backAllan Sandfeld Jensen2019-01-224-3/+26
| | | | | | | | | | Change-Id: If47d9bb5b77a369442b4df576629512fc8635144 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Windows post-merge fixupsAllan Sandfeld Jensen2019-01-2227-45/+98
| | | | | | | | | | | | | | Fixups for building Chromium 71 on MSVC. Change-Id: If8b364890c826a398a72604c00dd211f16de533a Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Run video capture on separate thread on macOSJüri Valdmann2019-01-221-1/+12
| | | | | | | | | | | | | | | | | | VideoCaptureDeviceFactoryMac needs a CFRunLoop-enabled thread, which the Qt main thread by default is not. Change-Id: I4a1b0f5f10bdd202d8b956a081551681cb874910 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Fix building on windows without toolkit_viewsAllan Sandfeld Jensen2019-01-182-2/+2
| | | | | | | | | | | | | | We don't use toolkit_views on any platform Change-Id: If56aada46ab540523d80675ed983c4104a6743b3 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Disable allocator checkPeter Varga2019-01-181-0/+2
| | | | | | | | | | | | | | Qt platform does not override default allocator. Fixes crash on macOS. Change-Id: I82d1fd165d83e678d9e370fc060819e2baa8dd57 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Fix jumbo build with GCCPeter Varga2019-01-171-0/+4
| | | | | | | | | | | | | | | | | | Always inline BasicStringPiece constructor to avoid linker errors with GCC 8.2. Task-number: QTBUG-71689 Change-Id: Ib573b035c19fa1e359935e83277ec9e174998bf8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Fix heap overflow when allocating PowerSaveBlockerMichal Klocek2019-01-172-2/+11
| | | | | | | | | | | | | | | | | | | | We are missing build flag when compilng wake lock, which creates missmach in PowerSaveBlocer class size. Done-With: Kirill Burtsev<kirill.burtsev@qt.io> Change-Id: Id27c1a5da34c92961d614f54feae1858ffcb6e1d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* | Minor. Remove old src version of sqliteMichal Klocek2019-01-17588-476475/+0
| | | | | | | | | | | | | | | | | | Remove old sqlite source code to avoid future misreference (src is using currently sqlite-src-3250200) Task-number: QTBUG-72632 Change-Id: I0300f4ff1b458d4e35e5eb01cc10603fbcc042f8 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* | Add extensions to Qt build and fix it up for buildingMichael Brüning2019-01-1718-15/+186
| | | | | | | | | | | | | | | | | | | | Jumbo patch that includes all the patches needed to enable the extension system for the Qt build. Currently used for conveniently moving the code around, but may become the actual change to get it merged upstream. Change-Id: Ie1920b31f9bbf40c8753cada2716d7f9fcb39280 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Post 71-merge fixupsAllan Sandfeld Jensen2019-01-175-5/+8
| | | | | | | | | | | | | | | | Fixes new asserts and build issues from the Chromium 71 code. Change-Id: I102539873f82bfd446cf034a2d97eb40d2dfb1f5 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | Make WebAuth optionalAllan Sandfeld Jensen2019-01-178-10/+34
| | | | | | | | | | | | | | | | We don't use it, and the code is terrible at cross platform support, and handling it takes up most of the adaption time. Change-Id: I1ac3165f736dea9ce9b9c26aa9afbac9355305c3 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | Move dcheck to source fileAllan Sandfeld Jensen2019-01-172-25/+29
| | | | | | | | | | | | | | | | | | Accesses details only defined in the source file. Likely only build for Google due to accidentently ending up in the same jumbo file. Change-Id: Ia6f6fc9ef973c79001a90f11e1f8e1b2958e2559 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Add missing GL_TEXTURE_2D macroTamas Zakor2019-01-151-0/+5
| | | | | | | | | | Change-Id: I2d30b238a3430312d779fbf338ae87274324eb05 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | FIXUP: Extend url library for WebEngine custom schemesAllan Sandfeld Jensen2019-01-093-4/+4
| | | | | | | | | | | | | | Re-enable custom scheme handling like for Android webview Change-Id: Icebfb1d96042e49b4923ea81ddbff1d5a3477337 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Do not bundle the tracing UI resourcesAllan Sandfeld Jensen2018-12-205-3/+34
| | | | | | | | | | | | | | | | We do not support loading the chrome://tracing WebUI and therefore we shouldn't bundle those resources in our library. Change-Id: If3aa4c676b22a55e772f19487e21b4cd48babe65 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | Add accessors and seams for the Qt delegated renderer integration.Allan Sandfeld Jensen2018-12-207-2/+38
| | | | | | | | | | | | | | | | | | | | | | | | This is needed to fetch the MessageLoop, the MailboxManager and the SyncPointManager of the GPU in-process host. And fetch the right shared context for the in GPU thread. Change-Id: I7f38e32b2df11da5b046f16643841d34260c11fb Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Add net::URLRequest::first_party_url()Tamas Zakor2018-12-208-0/+54
| | | | | | | | | | | | | | | | | | Returns the top level frame URL. Used instead of site_for_cookies() in case of cross-origin iframe navigations. Task-number: QTBUG-70790 Change-Id: Icec4beddd70b20120d53e17a35385d83d1276ac2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Fix idle detection with X11 OzoneAllan Sandfeld Jensen2018-12-203-15/+16
| | | | | | | | | | | | | | Only depend on use_xscrnsaver, not on using the X11 backend. Change-Id: I64d63332d98cd83fcaf47515a3e8048aac22c737 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Fixing zlib thumb issuesMichal Klocek2018-12-201-1/+1
| | | | | | | | | | | | | | | | | | Fixes builing zlib without thump. Also fixes bogus check for thumb in zlib Change-Id: I5548b5a8ae351ae872e02441d869b3cd7bc5d426 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Fix building skcms with intel ccAllan Sandfeld Jensen2018-12-201-2/+2
| | | | | | | | | | Change-Id: I25a4e5185566a542e909971c8479cc053ac457a1 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
* | Make sure we do not use png for host buildMichal Klocek2018-12-201-0/+2
| | | | | | | | | | | | | | | | Adds assert. Task-number: QTBUG-68090 Change-Id: I7aa153df99002ecd7b28081f2cfdb6b768cdcc49 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Do not make tools for webkit layout testsMichal Klocek2018-12-201-1/+1
| | | | | | | | | | | | | | | | | | This drops requirement for png being needed by host tools (imagediff). Task-number: QTBUG-68090 Change-Id: Ib11c37c7404a66fe9455433676d6fd80222604c0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Stop orphan child processes from staying alive on WindowsAlexandru Croitor2018-12-202-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Starting with Qt 5.11, on Windows, when the main WebEngine process crashed, the child render process would stay alive and use a whole CPU core trying to do something. What happened was that an existing layer tree frame sink was invalidated, and a request to create a new one was issued via RequestNewLayerTreeFrameSink, which failed due to the main process being dead, which scheduled a new request, and so on, which caused the child process main thread message loop to never exit. In Qt 5.10, this did not happen, because when the first request to create the sink failed, a new "software sink" was successfully created that did not depend on the host GPU process thread (see RenderThreadImpl::RequestNewLayerTreeFrameSink in render_thread_impl.cc). Thus the message loop ran out of tasks to execute, and could gracefully quit. The "software sink" code branch was removed in Qt 5.11+. Thus the hacky fix is to try and create the sink only a certain amount of times, and stop scheduling new requests after that. Task-number: QTBUG-69030 Change-Id: Iefd302aac48aa8729d8289490ddb310a5037ad96 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Cherry-pick certain macOS V2 sandbox rules into the V1 sandbox rulesAlexandru Croitor2018-12-201-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Certain UI controls weren't displayed correctly (like select fields, radio boxes, checkboxes) when the macOS sandbox was enabled. These were fixed for the second version of the sandbox "V2", but WebEngine does not currently work with it (missing code and additional rules to allow accessing Qt files). Backport the necessary sandbox permission rules from the "V2" version to the "V1" version, to allow correctly drawing the previously mentioned UI controls. Task-number: QTBUG-70715 Change-Id: I329433a311de58ea97e4e719e8c330568d578fa8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Disable some DCHECKs to fix printingSzabolcs David2018-12-202-2/+2
| | | | | | | | | | Change-Id: Ie30a7514b1538b243f3bfe16709fcc9c8209fc12 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Fix building with MSVCAlexandru Croitor2018-12-201-0/+4
| | | | | | | | | | | | | | | | | | | | | | The compiler somehow gets confused about which division operator to use when accessing a bitset. Output the flags as a simple int, instead of a bitset when building with MSVC. Change-Id: Ib95ea5c2da0b3806cb2138454a47825fd7c59c1a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
View Lorry Controller Status