summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix jumbo builds for windows88-basedAllan Sandfeld Jensen2021-06-251-0/+3
| | | | | Change-Id: Ia78d685919a5d217789a58fc1952dccfc13d4100 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix missing deps for extensions apiMichal Klocek2021-06-251-1/+2
| | | | | | | | | | | | | | Since a0cbfced7 we dropped dependecies in extensions/api this leads to build races. Fix for now issue with missing generated hader: chrome/common/extensions/api/webrtc_logging_private.h //chrome/browser/extensions/api:api_registration should depend on //chrome/common/extensions/api Change-Id: Ibbd036b071581448ab2c43452f322b8bbcdcffb1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Enable in-process vulkanJüri Valdmann2021-06-222-2/+15
| | | | | Change-Id: I0cc4822112032d1fed7529d39c7f51684104840d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* FIXUP: Stop using C++20 initializationJüri Valdmann2021-06-221-2/+2
| | | | | | | | C++20 initialization clears unmentioned fields to zero, unlike C initialization. Change-Id: I75d859635e723a44ed448e901766d39b6f063835 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* FIXUP: Use ui::Compositor (3rdparty)Jüri Valdmann2021-06-225-0/+35
| | | | | | | | Pass frame sink id to SkiaOutputDevice and intercept output device creation in SkiaOutputSurfaceImplOnGpu::InitializeForGL. Change-Id: I7ef36e4f029fe4bf853960442b9b80bff73f918f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* FIXUP: Use ui::Compositor (3rdparty)Jüri Valdmann2021-06-224-4/+16
| | | | | | | | | | Refactor how frame sink id is passed to OutputSurface implementation. Use dedicated method viz::OutputSurface::SetFrameSinkId instead of getter on Display. Change-Id: I0ffc13d524c4559517d72858839bd7ba50610b09 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add media:media_buildflags to public dependenciesAllan Sandfeld Jensen2021-06-171-0/+1
| | | | | | | | It used from content_switches.h Task-number: QTBUG-94572 Change-Id: I26cf7050f607a6941841a78354ead0ec3598a9a2 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Generate mojo bindings before compiling extension API registrationAllan Sandfeld Jensen2021-06-091-0/+1
| | | | | | | Add the dependency where it is used. Change-Id: Iff1dee5198a1ceef496e3e948ac61562717ce0e5 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Try to fix finding xkbcommon.h on OpenSUSEAllan Sandfeld Jensen2021-06-071-0/+10
| | | | | | | | The header is in /usr/include/libxkbcommon/xkbcommon/ so we need the includepath from pkgconfig. Change-Id: I1140cac4687f2c29888051afc6ce56280482a073 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* FIXUP: Stop using C++20 initializationAllan Sandfeld Jensen2021-06-031-3/+4
| | | | | Change-Id: I9e37be0dfa3f6bafbf448cae7c0064de0600cef3 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix build error for macOS arm64 on x86_64Michael Brüning2021-06-021-5/+1
| | | | | | | | | | | | When building for arm64 on an x86_64 macOS, the header files for the arm platform will be included, but ARCH_CPU_AR_64 is not defined. This lead to checking non-constexpr vm_page_size in a static_assert even though a DCHECK should be used for arm64. Use the DCHECK unconditionally on macOS builds to fix this. Change-Id: Iffa7e2de76358d3bb26473226e1c2a1ef6e0c356 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix arm64 Skia build for macOSMichael Brüning2021-06-021-2/+8
| | | | | | | | The cast that we use to compile on aarch64 without fp16 caused a compilation error for macOS arm64. Re-establish the upstream version for this case. Change-Id: Ic4c4c20f9502bf5ae716956efaa87a15026f8a29 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Make convert_dict as a root projectMichal Klocek2021-06-011-25/+13
| | | | | | | | | Move covert_dict to be defined in root BUILD.gn This change is required to build qwebengine_covert_dict with cmake. Change-Id: I55622d9fedf76ffbb28ebd928537722e4ed20743 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Adapt favicon and history component for WebEnginePeter Varga2021-05-3117-0/+161
| | | | | | | | | | | | | - Remove component/sync dependency of component/history - Add FaviconHandler::Type() to support toggle touch icons at runtime - Add FaviconHandler::Delegate::OnHandlerCompleted() to notify when icon downloading is done - Make FaviconHandler and FaviconService working when HistoryService is not set due to off-the-record profile Task-number: QTBUG-51184 Change-Id: Ic596f216b270ac4b76f0f37feb6d523d50592aae Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add support for QT_GN_VERSIONMichal Klocek2021-05-282-2/+24
| | | | | Change-Id: If5ac705f3a4292da915d1f36526ef1fbed3868e6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Workaround revoked certificate check on LinuxPeter Varga2021-05-261-1/+1
| | | | | | | | | | | Comparing std::string with base::BasicStringPiece<std::string> doesn't seem to work properly in std::binary_search(). Task-number: QTBUG-91467 Change-Id: I535faa358e3ce20ddb87a0830aa97fa1953d5994 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> (cherry picked from commit 5b2293cf1f238916da5cb40c4746dd987c071abd) Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix missing dependency for qtwebengine/browser/pdfMichal Klocek2021-05-131-0/+1
| | | | | | | | | | | From time to time with extensions build on we get: chromium/qtwebengine/browser/pdf/pdf_extension_util.cc:49:10: fatal error: 'chrome/grit/generated_resources.h' file not found Add missing dependency. Change-Id: Idf73253da7a1cda3b358d4e5fac7c593085695dc Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix gn build windows issueMichal Klocek2021-05-131-1/+1
| | | | | | | | | | CMake uses a compiler for a linker step, which we also pass as a linker to gn build, fix the build template to use cl as a linker. Task-number: QTBUG-91760 Change-Id: I9bc7472dfc709887f0a348ff6573b7580a6737bf Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add cmake link writer for specific configurationMichal Klocek2021-05-1314-131/+111
| | | | | | | | Remove old qmake implementation. Task-number: QTBUG-91760 Change-Id: Ia0ef4115dfb9f87bcf2853c40d8b082942f04ff2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* [Backport] CVE-2021-21201: Use after free in permissionsBalazs Engedy2021-05-1214-67/+129
| | | | | | | | | | | | | | | | | | | Partial backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2791431: Use IDType for permission change subscriptions. Bug: 1025683 Change-Id: I3b44ba7833138e8a657a4192e1a36c978695db32 Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Yuchen Liu <yucliu@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Illia Klimov <elklm@google.com> Auto-Submit: Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add first_party_url for net::SiteForCookiesTamas Zakor2021-05-1211-10/+76
| | | | | | | | | | | | | | | | This change brings back the behavior when the site for cookies was stored as an URL before Chromium 81. QtWebEngine implementation relies on that becuase it uses SiteForCookies to provide first party url in some cases. The site for cookies url was replaced by net::SiteForCookies in change https://chromium-review.googlesource.com/c/chromium/src/+/1925189 Task-number: QTBUG-90231 Change-Id: Ie1e4be21535a646699b031c3a2ebdb0a19617fc7 Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org> Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix crashes on getUserMediaRequestMichal Klocek2021-05-101-0/+5
| | | | | | | | | | | | If the build is compiled with no webrtc, the platform abstraction will return no VideoCaptureImplManager and this is not handled well within LocalVideoCapturerSource. After a short call stack analysis, it seems the most suitable place to bailout is in the user media processor, report no hardware as in unit tests. Change-Id: I75c92e4fe8869d6f3fb6831e8bf24c982d0b347c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Avoid crashing on new window in cross-origin isolated contentAllan Sandfeld Jensen2021-05-101-4/+5
| | | | | | | | | | | | The case seems to trigger if the opener is coop-coep-cross-origin- isolated, the load is speculative, site-related and not (yet) similarly isolated. The latter might be a separate/underlying bug though Change-Id: I9aacc1611ececc91425efe8a1c84ea941b575669 Fixes: QTBUG-92110 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix perfetto build for GCC 11Peter Varga2021-05-071-0/+1
| | | | | Change-Id: I812059fb02597cad329907e026a7c8afe839d04c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Make clang to inline load/store atomic calls for YieldSortKey structKirill Burtsev2021-05-061-1/+1
| | | | | | | | | Is needed for linux-clang spec build to not depend on atomic lib Task-number: QTBUG-93294 Change-Id: I9fcb275b9dd7973653c7897c1e19ddb9f6daeb58 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io> (cherry picked from commit 1d3b13e963467a19ebdd515431464771f513f6ef)
* Enable XkbKeyboardLayoutEngine::SetCurrentLayoutByName for QtPeter Varga2021-05-061-2/+2
| | | | | | | | | It is used for Keyboard.getLayoutMap() on Linux. Task-number: QTBUG-92971 Change-Id: I86ff88edd4de3f4b6c7f7e2deaf6c9c522cc0fcd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit f6730fe81a09266e29d7e5ea43f1d436d14dc610)
* FIXUP: Fixes for jumbo buildAllan Sandfeld Jensen2021-04-1612-42/+33
| | | | | | | Enabling jumbo in more directories Change-Id: I74a4c38fcc04c82dbcc381a93247299a6bf5bf7a Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Work-around linker error on armv7Allan Sandfeld Jensen2021-04-161-1/+1
| | | | | | | | | | We get undefined reference to kNoCropRect in CropRect(const SkIRect* optionalCrop), so instead use CropRect(const SkIRect& crop), since the pointer isn't nullable anyway. Change-Id: Id02deec1c57abd8d34fda70673c5973626000e96 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* FIXUP: Windows fixes after 88-mergePeter Varga2021-04-161-4/+2
| | | | | | | | | | Remove ContextLifecycleNotifier build fix for Windows. It breaks Linux build with disabled jumbo and the windows build issue is not reproducible. Change-Id: I0ebddd2c25a9adb8b76dc3209931c92218310f4d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix build with no extensions on macMichal Klocek2021-04-161-3/+6
| | | | | | | | | With following change we no longer can compile with no extensions: https://chromium-review.googlesource.com/c/chromium/src/+/2272030 Remove gn assertion in favor of the condition. Change-Id: I008e38a06db8397cd6632e559062fcf8aea614aa Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* FIXUP: Allow overriding GetXDisplayJüri Valdmann2021-04-151-7/+1
| | | | | | | | Chromium now relies on a global Xlib error handler being set, otherwise a single X11 error will result in exit(1). Change-Id: Iedd87de9b8b4c6bffec5dcb4d78fb0ea574ce319 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix for our testsAllan Sandfeld Jensen2021-04-133-11/+18
| | | | | Change-Id: Ia2bf55a221161e4b404f47b4c9f4e9a5111ddd56 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fixup user-agent override for new tabs againAllan Sandfeld Jensen2021-04-132-1/+9
| | | | | | | Just short-cut it. Change-Id: Ib1ffb39496ac8d022e5426d7ce211c6e44ecf2b5 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fixups post 88 mergeAllan Sandfeld Jensen2021-04-1313-34/+44
| | | | | Change-Id: I96bba31d5a88999af8c78751c1ee6d3aaf722b48 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix ios build issues for 83 adaptationsMichal Klocek2021-04-128-2/+28
| | | | | | Change-Id: I1d73d4726f955e3a555b3a389d1422638a2b1c5e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Add fat build supportMichal Klocek2021-04-125-6/+38
| | | | | | | | | | | | | | | | | | | | | Gn support fat builds with additional_target_cpus, however this expects only fat builds for same type of architecture like for ex. arm and arm64. Qt build does fat builds for arm64 and x64, this is tricky to support and would require some changes to support parsing builds with two acitve toolchains. Add poor man workaround to compile x64 together with arm64, by using Xarch to separate parameters. Unfortunately arm64 includes neon files by default which can not be compiled for x64. Therefore for release builds it is adviced to do CONFIG-=simulator, which will not compile for simulator, however will include NEON for arm64. Task-number: QTBUG-77931 Change-Id: I26f9a656187a205ce8448eb3b888201c786476c7 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Windows fixes after 88-mergeAllan Sandfeld Jensen2021-04-0839-39/+101
| | | | | Change-Id: I33566392bd4917a65213a21a8a0a277f9e2da8f8 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fixes for building with MSVC standard library after 88-mergeAllan Sandfeld Jensen2021-04-073-10/+57
| | | | | Change-Id: Ic404be54d4c783489b64d07d8d2cc0c758df33a7 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix crashes when webrtc is not compiled inMichal Klocek2021-04-061-1/+4
| | | | | | | This fixes qwebengineview test crash without webrtc. Change-Id: Ic2a597d2628a52985fc00ae146ab40d4c516080a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix PDF viewer after 88-based mergeSzabolcs David2021-03-262-0/+8
| | | | | | Change-Id: I8f81cbca31e5575050e6dae177154cc149466a69 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Remove linking with libatomicMichal Klocek2021-03-267-2/+14
| | | | | | | | Rhel machines on ci do not have it. Change-Id: I4cbb6d9d0826a23f8065a9eebba7ba27856e44d4 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix gn compilation on mac with Xcode 11.4Michal Klocek2021-03-231-0/+2
| | | | | | | | | | | | | | | | | | | | | | Update to Xcode 11.4 introduces new weak symbol which breaks gn linking with: Undefined symbols for architecture x86_64: "___darwin_check_fd_set_overflow" This symbol is declared by FD_SET macros referenced in exec_process.c and mark for weak linking, resulting object file has undefined weak symbol: (undefined) weak external ___darwin_check_fd_set_overflow Unfortunately during linking this is not handled properly without 'isysroot' parameter passed to linker. Fix it in gn build script. Change-Id: Ibb4c38aad098da1e119253cd89eba0216a921164 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit d5c4b6230b7f915f6e044e230c0c575249938400) Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix WebRtcLoggingController for QtWebEngineAllan Sandfeld Jensen2021-03-161-3/+4
| | | | | | | | | We don't have a WebRtcEventLogManager. Fixes: QTBUG-91857 Change-Id: I70e1ab23c9bc0672856321d78ef66e2cb6b9d88e Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix multiple include dirsAllan Sandfeld Jensen2021-03-161-1/+1
| | | | | | Fixes: QTBUG-91799 Change-Id: I05b96e19d5137275fccdec8fe10e8c14129a0a69 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Prepare net-internals for QtWebEngine usageAllan Sandfeld Jensen2021-03-161-2/+0
| | | | | | | These two headers aren't even used. Change-Id: Ic19f3270c424836fcc533d949bf38f59e26424bf Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Enable plugin.mojom for plugin placeholderTamas Zakor2021-03-162-0/+47
| | | | | | Task-number: QTBUG-82012 Change-Id: I5461c8c31406cfc3a1bf54cad9b10af639e9c4d3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Speculatively fix MIPS64EL buildAllan Sandfeld Jensen2021-03-161-0/+1
| | | | | | | Using variable defined here Change-Id: I2ef4584b869ad8cf946133fc3b77b8bd4d0bcc8f Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Make nss certificates disableable for QtPdfAllan Sandfeld Jensen2021-03-161-2/+4
| | | | | Change-Id: If907fc6b34a567db339f092b118d55dab546b04b Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix memory thresholds over 20GiBAllan Sandfeld Jensen2021-03-161-2/+2
| | | | | | | Hits overflow otherwise. Change-Id: If2cf9aa2bb0d4a498dcb4bfccc2d20bee374e488 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Enable build of tracing UIPeter Varga2021-03-162-3/+3
| | | | | Change-Id: Ie01ef53a6a264019eb61980927aa2ad781c5459d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>