summaryrefslogtreecommitdiff
path: root/chromium/content/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fixup: [Backport] CVE-2020-16001: Use after free in mediaMichael Brüning2020-10-261-2/+2
| | | | | | | The constants were moved into the blink::mojom namespace. Change-Id: Id302cdc95048f3dd6aceb2fb183a31555e11181b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* [Backport] CVE-2020-16001: Use after free in media.Michael Brüning2020-10-222-1/+8
| | | | | | | | | | | | | | | | | | | | Manual backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2472397: Validate input of MediaStreamDispatcherHost::OpenDevice() This method forwards to MediaStreamManager::OpenDevice(), which DCHECKs for the stream type to be device video or audio capture (i.e., webcam or mic). However, MSDH admits other stream types, which cause MSM::OpenDevice to hit this DCHECK. This CL ensures that a message containing an incorrect stream type, which could be sent by a malicious renderer, results in killing the renderer process. Bug: 1135018 Change-Id: I3884dde95d92c41f44966a8ab1dd7bdfd4b23b9b Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 6475589b7edc2f70f1b9fd4c1cf49b39d82b267b)
* [Backport] CVE-2020—15973: Insufficient policy enforcement in extensions (2/2)Marijn Kruisselbrink2020-10-213-4/+15
| | | | | | | | | | | | | | | | | Manual backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2330314: [FileAPI] Split BlobUrlRegistry of from BlobStorageRegistry. In preparation for making BlobUrlRegistry per storage partition, this cleans up the code a bit by moving all the blob URL logic to a separate class. This CL itself should not have any behavior changes, it is purely moving code around. Also fixes some naming inconsistencies (URL vs Url among others). Bug: 1106890 Change-Id: I0e7f9f8597d280ee2f69286c5a35cbb3997c9d9f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* [Backport] CVE-2020—15973: Insufficient policy enforcement in extensions (1/2)Marijn Kruisselbrink2020-10-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Manual backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2330311: [FileAPI] Refactor how BlobURLLoaderFactory works. Rather than resolving a mojo Blob to a BlobDataHandle, just forward the request to the Blob and let the blob create the URL Loader. This way we decouple BlobURLLoaderFactory from any blob internals, paving the way for further separating out the blob URL registry from the rest of the blob system, making it easier to change where parts of the blob system live (for example moving Blob URLs to be per storage partition, or in the future perhaps per agent cluster). This does increase binary size significantly because the added mojom method results in java bindings being generated for a lot of interfaces and structs that were previously not generated. In the future this increase can be eliminated by making it possible to tag methods in mojom files with what languages they should create bindings for, or by rewriting BlobURLLoader itself to operate on a mojo Blob, rather than forward the entire URLRequest to the mojo blob (https://crbug.com/1111835). Bug: 1106890 Binary-Size: Size increase is unavoidable (see above). Change-Id: I4fa3c6a5ddf6f8be5ce299e9d1fd95eaef75ec5e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* [Backport] Security bug 1125199Bruce Dawson2020-10-211-2/+4
| | | | | | | | | | | | | | | Manual backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2407065: Avoid use-after-free SetNotWaitingForResponse can trigger a message pump which can then free the object which |this| points to. This use-after-free can be avoided by not dereferencing |this| after the call, by ensuring that calling SetNotWaitingForResponse is the last thing done. Bug: 1125199 Change-Id: Ie1289c93112151978e6daaa1d24326770028c529 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* [Backport] CVE-2020-15978 Insufficient data validation in navigationLukasz Anforowicz2020-10-211-0/+5
| | | | | | | | | | | | | | | | | Manual backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2385921: Avoid fixing/rewriting/mutating invalid URLs in RewriteURLIfNecessary. This CL changes BrowserURLHandlerImpl::RewriteURLIfNecessary so that it returns early(and doesn't mutate the |url| in the in-out argument) if |url| is invalid. This helps avoid scenarios where RewriteUrlForNavigation (in navigation_controller_impl.cc) ends up generating a NavigationEntry with an invalid virtual URL that (accidentally/incorrectly) gets rewritten into a valid URL. Bug: 1116280 Change-Id: I114cf8c8d9459b6931ae659f62a100679b994d5e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* [Backport] CVE-2020-15961: Insufficient policy enforcement in extensionsAndrey Kosyakov2020-09-221-1/+21
| | | | | | | | | | Manual backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2380855: Delegate TargetHandler::Session permission checks to the root client Bug: 1114636 Change-Id: Iba3865206d7e80b363ec69180ac05e20b56aade2 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* [Backport] CVE-2020-15963 and CVE-2020-15966Andrey Kosyakov2020-09-223-14/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Manual backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2368446: Reland "Add more checks for chrome.debugger extensions" This reverts commit 5a809a08fd5ca32cb8d594664416db2f2dc8ebdc. Reason for revert: I don't think the test failure is related. Please note it stopped before the revert landed (build no 91007 vs. 91010). This must have been a flake, or a independent failure that has been fixed by one of the front-end rolls. Original change's description: > Revert "Add more checks for chrome.debugger extensions" > > This reverts commit 4838b76ae48797760fd8a362b4dc15325ccddcf5. > > Reason for revert: 1119297 > > Original change's description: > > Add more checks for chrome.debugger extensions > > > > Bug: 1113558, 1113565 > > Change-Id: I99f2e030f9a38f1ffd6b6adc760ba15e5d231f96 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342277 > > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#799514} > > TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,caseq@chromium.org,yangguo@chromium.org,sigurds@chromium.org > > Change-Id: I01ad12ca99ac75197f9073e2c6c9d0eaa0d95147 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1113558 > Bug: 1113565 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362920 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799558} TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,caseq@chromium.org,yangguo@chromium.org,sigurds@chromium.org,dullweber@chromium.org Bug: 1113558 Bug: 1113565 Change-Id: Ic98fc037028a210204b7935b0b8e50e4e36e2397 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#800682} Change-Id: Ie63da838a9432e8e49218ba774204fd22a3ce5ce Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* [Backport] CVE-2020-6573: Use after free in videoGuido Urdaneta2020-09-221-0/+4
| | | | | | | | | | | | Manual backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2376812: [VideoCapture] Remove references to launched device before it is reset This removes potential dangling pointers remaining in buffer contexts. Bug: 1116304 Change-Id: I8fca66d22b618de7e6f60b1666985099d4fe9d7e Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* [Backport] CVE-2020-6561: Inappropriate implementation in Content Security ↵Antonio Sartori2020-09-211-0/+2
| | | | | | | | | | | | | | | | | | | | | | | Policy Manual backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2181363: Use original URL before redirects as blocked URL in CSP reporting When a resource was being blocked because of a Content Security Policy violation after a redirect happened, we were using the final URL (after the redirect) in the CSP reporting. This is a security issue, since it could expose confidential information such as a token contained in the redirect URL. As stated in https://w3c.github.io/webappsec-csp/#create-violation-for-request ("We use request's url, and not its current url, as the latter might contain information about redirect targets to which the page MUST NOT be given access."), whe should instead report the request's original URL. Bug: 932892 Change-Id: I1864e6e9e4cc266615e49276012ba7f9d96672f7 Fixed: 932892 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* [Backport] CVE-2020-6531: Side-channel information leakage in scroll to textDavid Bokan2020-09-111-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Manual backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2135407: Fix text fragment for user activation For security reasons, text fragments must only be activated when navigated with a user gesture. However, browser initiated navigations (e.g. user typing in the omnibox, bookmarks) don't have the user gesture bit set despite being initiated by the user (see discussion in https://crrev.com/c/2132673 for details). Because of this limitation, text fragment code explicitly checked if the navigation was browser initiated, assuming that such navigations are always user activated. However, history navigations are a special case. They're intentionally considered to be browser initiated, even if they originate from renderer script (e.g. `history.back()`). This meant that our check above would allow script to use the history API to activate a text fragment without a user gesture. This CL explicitly forbids activating a text fragment if the navigation is of history type. This is a trivial change (in terms of UX) because a history navigation will restore the scroll position to where the user left off so the text fragment scroll is already clobbered. This change prevents a transient scroll that will be undone. Note: we had an explicit test for this case that failed to catch the failure. The reason was that the test was checking that the fragment wasn't activated by checking that the scroll offset after a navigation is 0. However, the text fragment's scroll would be clobbered (assuming by history scroll restoration) so this check would erroneously pass. We fix it in this CL by using a scroll listener so that we can tell a scroll occurred even if it is later restored. Bug: 1042986 Change-Id: Ia0ad9a8adcda2250603e6a7dd2b386193be2a6e6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* [Backport] CVE-2020-6530: Out of bounds memory access inAndrey Kosyakov2020-09-111-0/+8
| | | | | | | | | | | | developer tools Manual backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2154228: DevTools: check whether Fetch domain is enabled before handling commands Bug: 1016278 Change-Id: Icd80e3b287f090ffb4ac67437e7e1ebae392c98b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* [Backport] Security bug 1090543clamy2020-09-111-0/+7
| | | | | | | | | | | | | | | Backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2254119: Guard against UaF in NavigationRequest This CL adds a check in NavigationRequest::OnWillProcessResponseProcessed to return early if the call to ReadyToCommit leads to the deletion of the NavigationRequest. Bug: 1090543 Change-Id: Ida21db80caef1772f2f21c5d2449d3efe4dd1bb1 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* [Backport] CVE-2020-6535: Insufficient data validation in WebUIdpapad2020-09-113-3/+8
| | | | | | | | | | | | | | | | | Cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2161355: Use parseHTMLSubset() in chrome://histograms. This prevents a maliciously created histogram name from injecting code (XSS) in the context of chrome://histograms. Fixed: 1073409 Change-Id: I75c9a26b95363cad4a470ed6488718421289961e Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#761723} Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* [Backport] CVE-2020-6510: Heap buffer overflow in background fetchRayan Kanso2020-09-102-10/+32
| | | | | | | | | Backport of patch originally revieweved on [BackgroundFetch] Handle race condition between click & completion event. Bug: 1103195 Change-Id: If658eb17cb883f7b3b177d62fc3a185421c5efae Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Allow --disable-gpu to disable gpu thread/processAllan Sandfeld Jensen2020-09-091-1/+1
| | | | | | | Chromium now only allows it on Windows and ChromeOS. Change-Id: Ifc5ccfca392769fed6329f209a16e2c315054512 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix build after 83-mergeAllan Sandfeld Jensen2020-09-084-0/+15
| | | | | | Change-Id: Ie864f66333b03c9ebc0551096aa91394e82fc421 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix build with gcc5 post 83 mergeAllan Sandfeld Jensen2020-09-031-1/+2
| | | | | Change-Id: Icc5bde087ec9ea9ec5eacc7aa15ff30425752afc Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* FIXUP: enable_webrtcAllan Sandfeld Jensen2020-09-032-1/+10
| | | | | Change-Id: I695a5398a5fb6819e9cb748890c1ca0d21ed687b Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fixups post 83-merge for WindowsAllan Sandfeld Jensen2020-09-024-5/+5
| | | | | Change-Id: I5d5d1205874d7333377875ab4071740dc98c6ec7 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix ServiceWorkerContainerHost crash with libstdc++Jüri Valdmann2020-09-021-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The crash can be reproduced with simplebrowser by 1) navigating to a page which uses service workers, e.g. https://googlechrome.github.io/samples/service-worker/basic/ 2) then navigating away, e.g. to about:blank, and waiting about 15s. The crash only occurs when compiled against libstdc++, but not with libc++. The crash is caused by a double destruction issue in ServiceWorkerContainerHost. ServiceWorkerContainerHost::RemoveServiceWorkerObjectHost calls erase() on the member field service_worker_object_hosts_ of type std::map<uint64_t, std::unique_ptr<ServiceWorkerObjectHost>>, whereafter ServiceWorkerObjectHost's destructor ends up causing the destruction of the original ServiceWorkerObjectHost and the std::map. This works fine with clang's libc++, but not with libstdc++ due to the different behavior of std::map::erase. With libc++, map.erase(x) first removes x from the map and only then destroys the x. With libstdc++, map.erase(x) also first removes and then destroys x, except when x is the only element in the map. In the latter case, as an optimization, map.erase(x) calls map.clear(), which first destroys x and then removes it from the map. So, if service_worker_object_hosts_ contains only one element, then with libstdc++, the element's destructor is called twice: once by std::map::erase and once by std::map::~map. With libc++, it's called only once since std::map::erase removed the element from the map and std::map::~map does not try to destroy it again. Fix by moving the element std::unique_ptr out of the map before calling std::map::erase. A similar issue might exist with RemoveServiceWorkerRegistrationObjectHost, so apply the fix there as well. Change-Id: I0364cb82776f21f29829cf6358eb121f91dc8223 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Cast the right side of a left shiftAllan Sandfeld Jensen2020-08-181-1/+1
| | | | | Change-Id: I1cbeefc92754ea11f5c4622cad055639d21fe4a8 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Decouple payment from contentAllan Sandfeld Jensen2020-08-185-0/+36
| | | | | Change-Id: I824859ff291b66016ec00d4d44172caeec2db34c Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Make navigation on back/forward mouse buttons optionalAllan Sandfeld Jensen2020-08-061-0/+2
| | | | | | | Makes it possible for us to keep behaviour consistent in Qt 5. Change-Id: I9c5fedce77158b576b4b9dac5d30807c976fa45f Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Pass through a new application name argument to utility processesAllan Sandfeld Jensen2020-08-061-0/+3
| | | | | | | | | Audio is now played by a utility process, but we need to tell PulseAudio which application is playing back. Task-number: QTBUG-85363 Change-Id: I3c9b364527b669d8cd2f2421034bc6b2f7b2b28e Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix crash in file-selector testsAllan Sandfeld Jensen2020-08-061-0/+4
| | | | | | | Make sure ResetOwner is called when the proxy is unset. Change-Id: Idbda789ec088697b99d0946769c04db031d7cafe Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix viz crash when cleanupMichal Klocek2020-08-062-2/+7
| | | | | | | | | | | | | | | | | When we cleanup viz, OnConnectionLost will delete frame_sink_manger. However we can still have messages to create sinks and to invalidate them later when destroying compositor. Also, the destructor of EmbeddedFrameSinkImpl may call UnregisterFrameSinkHierarchy on shutdown. Do not create new frame sink, and do not invalidate them later. Make possible to bail out in viz process transport factory as compositor was already deleted. Task-number: QTBUG-83040 Task-number: QTBUG-79864 Change-Id: Ibf0606368dfd81bc376a06721ada8d13cd8ea417 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Stop sending ViewMsg_SetBackgroundOpaque to rendererJüri Valdmann2020-08-061-0/+2
| | | | | | | | We are using RenderViewObserverQt_SetBackgroundColor instead. The two conflict because both call SetBaseBackgroundColorOverride on the WebView. Change-Id: I02bed3f06af2bbb01d2a7f8964492f7d5f5559a5 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fixes for jumbo buildAllan Sandfeld Jensen2020-08-063-7/+16
| | | | | | | Fixes necessary to make jumbo build work Change-Id: I1551ddeaa15fdc4e9db72e86ea49191193cb4964 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Destroy old network context before creating the replacementAllan Sandfeld Jensen2020-08-061-1/+5
| | | | | | | Helps with updating primary network contexts. Change-Id: Ia8a4f366951128f5501b9f684f84faa02fe458b2 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Expose StoragePartitionImpl::InitNetworkContextJüri Valdmann2020-08-061-0/+4
| | | | | | | | | Allows recreating the NetworkContext used inside a storage partition so as to change network settings dynamically. Task-number: QTBUG-81558 Change-Id: I7b4b0a7d203eed976e13fdf3dbd4375acdae6265 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* FIXUP: Fixes for building with MSVCPeter Varga2020-08-061-2/+6
| | | | | Change-Id: Ifa97b9cf29666355154effc5478c09b9ef941a87 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fixes for building with MSVCAllan Sandfeld Jensen2020-08-062-1/+3
| | | | | | | Work-around various issues to make Chromium build on MSVC Change-Id: I3489452c9d7e61243fb60b877d289293b1850ebe Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix access after moveAllan Sandfeld Jensen2020-08-061-2/+2
| | | | | | | | We can't both access and move an object in the same expression. This is undefined behavior and causes crashes with gcc 5. Change-Id: I916927c27c7dec0f15620dfd22c795267a6bddc0 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix build on windowsAllan Sandfeld Jensen2020-08-062-3/+1
| | | | | | | More fixups for building on Windows. Change-Id: I2723b4467836def3087f9667b54101e965a7abfd Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix WebAuth and building with gcc 6/7Allan Sandfeld Jensen2020-08-062-3/+2
| | | | | | | | | | | - Enable typemaps.gni for WebAuth. - Workaround a gcc 6 compiler error when flat_map is uncopyable. - Also fix the build with gcc 6 and gcc 7. Task-number: QTBUG-54720 Task-number: QTBUG-85117 Change-Id: If73ce3fccdb7fc3dc2cddd39bba998f51956e45a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix building with GCC 6Allan Sandfeld Jensen2020-08-067-113/+142
| | | | | | | Change-Id: Iaac84a496d65fda30ab1fab536e27daaad8d0e0d Reviewed-by: Michal Klocek <michal.klocek@qt.io> Change-Id: If3139faae45765b18dc680ffebb6c5f690045eeb
* Fix building with gcc 5Allan Sandfeld Jensen2020-08-066-62/+63
| | | | | | | | Working around various issues with gcc, and inconsistent use of constexpr. Change-Id: Iec46c4362f57d6aa7a8a37784dfe46c0b6563044 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix building on macOS with XcodeAlexandru Croitor2020-08-061-2/+2
| | | | | | | | Fixes various issues were we differ from Google's clang. Task-number: QTBUG-60438 Change-Id: I5a97ba828f7267731e50010c4345caa19bb8939a Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Do not bundle the tracing UI resourcesAllan Sandfeld Jensen2020-08-062-3/+7
| | | | | | | | We do not support loading the chrome://tracing WebUI and therefore we shouldn't bundle those resources in our library. Change-Id: If3aa4c676b22a55e772f19487e21b4cd48babe65 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix 32bit sandboxing on WindowsAllan Sandfeld Jensen2020-08-061-1/+1
| | | | | | | | Static linking would lose essential symbols, we need it to be a source_set, but can make the places that uses it static_libraries instead. Change-Id: I77454a217c937117d497330b023da6fa45c95d0f Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix FlingScheduler in viz modeJüri Valdmann2020-08-061-0/+4
| | | | | | | | FlingScheduler needs access to our ui::Compositor in RWHVQt if in viz mode. Task-number: QTBUG-80089 Change-Id: I1628cb7bbeca95101ae0db83a559c3ff56cbadc6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix changing should_override_user_agent_in_new_tabs_Allan Sandfeld Jensen2020-08-061-2/+1
| | | | | | | It wouldn't be updated if the custom user-agent didn't change. Change-Id: Ic31ef485e2cb84903f9b48cb9ad5f9f1a723eb92 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fixes for post 79-mergeAllan Sandfeld Jensen2020-08-062-6/+6
| | | | | Change-Id: I2b22cb0e6aaa0c503e2ead7c1c86e50c6be3ccf3 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Bring enable_webrtc backAllan Sandfeld Jensen2020-08-0615-50/+165
| | | | | | | | | | | | Returns the GN args and BUILDFLAG to disable WebRTC code shrinking the Chromium binary by a 15%. Reverting https://chromium-review.googlesource.com/1044220, https://chromium-review.googlesource.com/1059408 and fixes later bitrot. Change-Id: Ic46c2832dbfacaeffa6a00a12a8a144cf0adf7f0 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Make WebAuth optionalAllan Sandfeld Jensen2020-08-065-16/+37
| | | | | | | | We don't use it, and the code is terrible at cross platform support, and handling it takes up most of the adaption time. Change-Id: I1ac3165f736dea9ce9b9c26aa9afbac9355305c3 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Fix building without WebSpeechAllan Sandfeld Jensen2020-08-066-42/+63
| | | | | | | | | WebSpeech requires Google API keys, so we do not support it, and disabling it also gets rid of libspeex and libFLAC. Change-Id: I80a54ec4c6a13ea4c443289aa42369196c2e095a Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Disable responsiveness watcherAllan Sandfeld Jensen2020-08-061-0/+2
| | | | | | | It uses implementation specific details that doesn't apply to us. Change-Id: Ic84f8046605cad4f84cf691f4bda0a51b7d620c9 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Protect against nullptr dereference in GetSelectedTextAlexandru Croitor2020-08-062-1/+6
| | | | | | | | | | | | Also remove the DCHECK in debug builds. Should fix the crashes in tst_QWebEngineView::inputContextQueryInput(). Note this is just a band-aid fix to prevent a crash, the underlying issue is still there. Change-Id: Ie416f3517896a0ad978540ae81d1401af4bfbacc Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Pass Qt Prefix path to the macOS V2 Seatbelt SandboxAlexandru Croitor2020-08-061-0/+15
| | | | | | | | | | | | | The render process requires access to the Qt resources directory (for ICU data files for example). Pass the Qt prefix path to the sandbox rules, to allow file read access. Change-Id: I2364ef4711d225aae2d14da78e33c609f4f8b5bd Fixes: QTBUG-73089 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
View Lorry Controller Status